Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update terms and privacy #786

Merged
merged 4 commits into from
Nov 2, 2023
Merged

Conversation

shelegdmitriy
Copy link
Contributor

@shelegdmitriy shelegdmitriy commented Oct 30, 2023

Closes #525 #526

  • Add a new route to our viewer /terms that will display the terms of use;
  • Update existing route for /privacy with the new privacy doc

@vercel
Copy link

vercel bot commented Oct 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
near-discovery ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 2, 2023 5:36pm
near-discovery-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 2, 2023 5:36pm

src/pages/index.tsx Outdated Show resolved Hide resolved
@shelegdmitriy shelegdmitriy force-pushed the feat/update_terms_and_privacy branch from 530f539 to 2024cd0 Compare October 31, 2023 17:14
@charleslavon
Copy link
Contributor

@shelegdmitriy what values should we use for these two new environment variables across Production and Development?

@shelegdmitriy
Copy link
Contributor Author

@shelegdmitriy what values should we use for these two new environment variables across Production and Development?

I've just added these two new environment variables to the Vercel and created a note in 1Password

src/pages/privacy.tsx Outdated Show resolved Hide resolved
src/pages/terms.tsx Outdated Show resolved Hide resolved
@shelegdmitriy
Copy link
Contributor Author

I found a problem with tables and some html tags on privacy page. That doc needs to be updated

@shelegdmitriy shelegdmitriy marked this pull request as draft October 31, 2023 22:44
@shelegdmitriy
Copy link
Contributor Author

There is small problem with a new privacy documents. This document contains a couple of tables and they can't be loaded/displayed properly on a page. Here is en example how it looks like right now:

Знімок екрана 2023-11-02 о 15 15 40

html tags are not a part of markdown syntax which means we have a few ways of how to solve this problem:

  1. First, and the most easy for me 🙂 is to ask somebody to change tables to lists of something else.
  2. I can convert such table to markdown syntax using library and upload new version of document to the infura account.

After conversation with @charleslavon we decided to go with option 2.

@shelegdmitriy shelegdmitriy force-pushed the feat/update_terms_and_privacy branch from 8247490 to 36cf9e7 Compare November 2, 2023 17:25
@shelegdmitriy shelegdmitriy merged commit 7657fe7 into develop Nov 2, 2023
4 checks passed
@shelegdmitriy shelegdmitriy deleted the feat/update_terms_and_privacy branch November 2, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature To highlight a PR's description in the 'New Features' changelog section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

P1 [NEARCON] Update Terms of Use
3 participants