Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure installation directory exists before downloading binary #97

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

pivanov
Copy link
Contributor

@pivanov pivanov commented Sep 3, 2024

  • Updated the download method in Binary class to be asynchronous.
  • Added a check to ensure the installDir directory exists before starting the download.
  • If the directory does not exist, it is created with fs.mkdir using the recursive option.
  • Add the bin folder in the npm package distribution, allowing necessary binaries to be available post-installation.

@race-of-sloths

  - Updated the `download` method in `Binary` class to be asynchronous.
  - Added a check to ensure the `installDir` directory exists before starting the download.
  - If the directory does not exist, it is created with `fs.mkdir` using the `recursive` option.
  - Add the `bin` folder in the npm package distribution, allowing necessary binaries to be available post-installation.
@pivanov pivanov force-pushed the fix/download-create-install-dir branch from 96f4752 to 2b5047c Compare September 4, 2024 07:41
Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@race-of-sloths score 5

@race-of-sloths
Copy link

race-of-sloths commented Sep 4, 2024

@pivanov Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
New Sloth joined the Race! Welcome!

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@frol 5

Your contribution is much appreciated with a final score of 5!
You have received 60 (50 base + 10 weekly bonus) Sloth points for this contribution

Another weekly streak completed, well done @pivanov! To keep your weekly streak and get another bonus make pull request next week! Looking forward to see you in race-of-sloths

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

@frol frol merged commit 0e5c372 into near:main Sep 4, 2024
4 checks passed
@race-of-sloths
Copy link

🥁 Score it!

@frol, please score the PR with @race-of-sloths score [1/2/3/5/8/13]. The contributor deserves it.
If no scoring is provided within 24 hours, this PR will be scored as 1 🦥

@frol
Copy link
Collaborator

frol commented Sep 4, 2024

@race-of-sloths score 5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants