-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: setup docker builds for contracts and add WASM check to CI #509
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this.
@@ -11,7 +11,7 @@ jobs: | |||
strategy: | |||
matrix: | |||
platform: [ubuntu-latest, macos-latest] | |||
toolchain: [stable-2020-10-08] | |||
toolchain: [stable] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you, why did we even have the other version. didn't notice 👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
idk it was the version used across the board before, I assume for consistency, but is counter-intuitive for a lib like the SDK
Awesome. at some point (doesn't have to be in this PR) we can probably let folks know (in the "Contributing" section of the README or something) that they don't need to revision Wasm binaries anymore. |
Closes #465
Supersedes #480 (kinda, this just switches the path to the docker image's path but is reproducible now)
Supersedes #461 (These were built before some other changes were done so this should update to current)