Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: setup docker builds for contracts and add WASM check to CI #509

Merged
merged 6 commits into from
Jul 29, 2021

Conversation

austinabell
Copy link
Contributor

@austinabell austinabell commented Jul 29, 2021

  • Sets up docker build scripts for examples
  • Updates buildkite script to use them and check for modified wasm blobs
    • This makes it so that any change that affects the binary must be committed with the change
  • Removes size check script, there is a bug in twiggy, which is being used

Closes #465
Supersedes #480 (kinda, this just switches the path to the docker image's path but is reproducible now)
Supersedes #461 (These were built before some other changes were done so this should update to current)

Copy link
Contributor

@chefsale chefsale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this.

@@ -11,7 +11,7 @@ jobs:
strategy:
matrix:
platform: [ubuntu-latest, macos-latest]
toolchain: [stable-2020-10-08]
toolchain: [stable]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, why did we even have the other version. didn't notice 👍🏼

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk it was the version used across the board before, I assume for consistency, but is counter-intuitive for a lib like the SDK

@mikedotexe
Copy link
Contributor

Awesome. at some point (doesn't have to be in this PR) we can probably let folks know (in the "Contributing" section of the README or something) that they don't need to revision Wasm binaries anymore.

@austinabell austinabell merged commit 7868e0f into master Jul 29, 2021
@austinabell austinabell deleted the austin/examples_docker branch July 29, 2021 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the container on DockerHub, add checks to CI
3 participants