Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recovery methods show up even when it's not profile owned by wallet #580

Closed
vgrichina opened this issue May 14, 2020 · 1 comment · Fixed by #534
Closed

Recovery methods show up even when it's not profile owned by wallet #580

vgrichina opened this issue May 14, 2020 · 1 comment · Fixed by #534
Assignees
@Patrick1904 @marcinbodnar
Labels
Bug Something is not working as it should

Comments

@vgrichina
Copy link
Contributor

Try opening e.g. https://wallet.testnet.near.org/profile/vg
Unless you own this account there should be no Recovery methods component, but it shows up.
@vgrichina vgrichina added the Bug Something is not working as it should label May 14, 2020
@Patrick1904 Patrick1904 mentioned this issue May 15, 2020
Merged
8 tasks
marcinbodnar added a commit that referenced this issue May 18, 2020
@marcinbodnar
Refactor loadRecoveryMethods and create separate wallet method (#580)
6189b55
marcinbodnar added a commit that referenced this issue May 18, 2020
@marcinbodnar
RecoveryContainer take recovery methods from redux state (#580)
c64bbd8
@marcinbodnar marcinbodnar linked a pull request May 18, 2020 that will close this issue
profile: display balance breakdown #534
Merged
8 tasks
@marcinbodnar
Copy link
Contributor

It needed some refactoring because RecoveryContainer was connected to redux, but it was still taking recovery methods as props from the Profile component, which was a bit unnecessary. Also since we can't fetch recovery methods for an external account I removed accountId param for loadRecoveryMethods action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Patrick1904 Patrick1904

@marcinbodnar marcinbodnar

Labels
Bug Something is not working as it should
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

profile: display balance breakdown near/near-wallet
3 participants
@vgrichina @Patrick1904 @marcinbodnar