Transfer Wizard Static page (with minor improvements) #3066
Conversation
|
Your Render PR Server URL is https://near-wallet-pr-3066.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-ci7oshdph6evb6n2srq0. |
✅ Deploy Preview for glittering-pavlova-0e9247 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for unrivaled-zabaione-2fe19c ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
| export const TransferWizardWrapper = () => { | ||
| return ( | ||
| <Container> | ||
| <h6>The following should be devised as a page on the wallet.near.org site to inform users about TW.</h6> |
There was a problem hiding this comment.
This looks like a placeholder, can we remove?
| return ( | ||
| <Container> | ||
| <h6>The following should be devised as a page on the wallet.near.org site to inform users about TW.</h6> | ||
| <h1 >Migrating from the Near Wallet</h1> |
There was a problem hiding this comment.
| <h1 >Migrating from the Near Wallet</h1> | |
| <h1>Migrating from the Near Wallet</h1> |
Also should it be just "Near Wallet" instead of "the Near Wallet"?
| <tr> | ||
| <Td> | ||
| <p><b>Step2. Clean Up Your Keys</b></p> | ||
| <p>Next, NEAR wants to reduce the amount of apps that you’ve shared keys with, similar to revoking access for third-parties. This may cause you to be disconnected from some apps.</p> |
There was a problem hiding this comment.
’
There are a few different escape codes in here: rsquo, nbsp, and amp. Can you please double check that these are all rendering correctly and consistently with the rest of the text? Or just replace with plain characters 👍
| @@ -1920,6 +1920,10 @@ | |||
| "rotatedKeyTooltip": "This key will be used to transfer the account to a new wallet.", | |||
| "currentAccessKeyTooltip": "This key will be automatically deleted when transfer process is completed." | |||
| }, | |||
| "cleanKeysComplete": { | |||
| "title": "Your keys have been cleaned up!", | |||
| "desc": "You will be redirect to the next step shortly to export accounts to other wallet." | |||
There was a problem hiding this comment.
| "desc": "You will be redirect to the next step shortly to export accounts to other wallet." | |
| "desc": "You will be redirected to the next step to export accounts to another wallet shortly." |
| @@ -116,6 +118,10 @@ const WalletMigration = ({ open, onClose }) => { | |||
| handleSetActiveView(WALLET_MIGRATION_VIEWS.MIGRATE_ACCOUNTS); | |||
| }; | |||
|
|
|||
| const natvigateToCleanKeysComplete = () => { | |||
There was a problem hiding this comment.
💄 should be navigateToCleanKeysComplete
|
@andy-haynes thank you for detailed review! |
This PR intend to improve the transfer wizard experience by following changes:
Wallet-selector update:
Static page related changes:
