chore: Expose tokens_burnt #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinabell
reviewed
Jul 13, 2022
Comment on lines
88
to
94
| logs: Vec::new(), | ||
| receipt_ids: Vec::new(), | ||
| gas_burnt: 0, | ||
| tokens_burnt: 0, | ||
| executor_id: "testnet".parse()?, | ||
| status: ExecutionStatusView::SuccessValue(String::new()), | ||
| }, |
There was a problem hiding this comment.
Wait, I'm so confused. Why are we even adding in a blank execution outcome here? Seems like a footgun
There was a problem hiding this comment.
yup, certainly not ideal. This was just mocked out at the time to get testnet going, but let's revisit it in a future issue/PR since it's going to require finding the actual transaction details themselves which the Helper Contract AFAIK does not provide additional details for when creating an account
|
@austinabell any other concerns for this one? Trying to get a release soon, and this will be nice to have in there as well |
austinabell
approved these changes
Jul 20, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose
tokens_burntfield inExecutionOutcome