Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inherits feat: Worker::patch PR #291

Merged
merged 15 commits into from
Sep 9, 2023
Merged

Conversation

ghost
Copy link

@ghost ghost commented Aug 24, 2023

Closes #250
This PR takes in work done by @ChaoticTempest and tries to address code reviews and finalise this PR #264 which has become stale.

@ghost ghost changed the base branch from main to feat/patch August 24, 2023 12:58
@ghost ghost changed the base branch from feat/patch to main August 24, 2023 12:59
@ghost ghost marked this pull request as ready for review August 25, 2023 10:08
@ghost
Copy link
Author

ghost commented Aug 29, 2023

@ChaoticTempest @frol I have picked this up issue and continued from where @ChaoticTempest left off (Hope that's okay)

Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good to me. Ready to merge it once the other comment is addressed.

workspaces/src/rpc/patch.rs Show resolved Hide resolved
@frol frol merged commit 9029d92 into near:main Sep 9, 2023
3 checks passed
@ghost ghost deleted the inherit-feat-patch branch October 3, 2023 16:07
@frol frol mentioned this pull request Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New patch state, key, account API
2 participants