Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fixed dev_deploy to use registrar account to create top-level accounts (nearcore 1.37.0+ forbidden to create top-level accounts by non-registrar accounts) #360

Merged
merged 6 commits into from
Jun 25, 2024

Conversation

fospring
Copy link
Contributor

@fospring fospring commented Jun 6, 2024

to fix issue: #354

@fospring fospring force-pushed the issues-354/dev_deploy_after_1.37.0 branch 2 times, most recently from 8b0db8f to 7646b15 Compare June 7, 2024 01:59
@fospring
Copy link
Contributor Author

fospring commented Jun 9, 2024

@frol pls take a look

workspaces/Cargo.toml Outdated Show resolved Hide resolved
@fospring fospring force-pushed the issues-354/dev_deploy_after_1.37.0 branch from 0768dd4 to 5f5896b Compare June 11, 2024 15:56
Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good. Please, address the comments and fix CI and we are good to go

workspaces/src/network/sandbox.rs Outdated Show resolved Hide resolved
workspaces/src/network/config.rs Outdated Show resolved Hide resolved
@fospring fospring force-pushed the issues-354/dev_deploy_after_1.37.0 branch from 65604da to 35281bb Compare June 23, 2024 17:58
@fospring fospring force-pushed the issues-354/dev_deploy_after_1.37.0 branch from 35281bb to 563f333 Compare June 23, 2024 18:01
@fospring fospring force-pushed the issues-354/dev_deploy_after_1.37.0 branch from 7f15bc4 to 480c1e8 Compare June 23, 2024 18:06
@frol frol changed the title feat-issues-354: dev_deploy after 1.37.0 feat: Fixed dev_deploy to use registrar account to create top-level accounts (nearcore 1.37.0+ forbidden to create top-level accounts by non-registrar accounts) Jun 25, 2024
@frol frol force-pushed the issues-354/dev_deploy_after_1.37.0 branch from ba815bd to cadb911 Compare June 25, 2024 17:18
@frol frol enabled auto-merge (squash) June 25, 2024 17:18
@frol frol merged commit 47941f0 into near:main Jun 25, 2024
6 checks passed
frol added a commit that referenced this pull request Jun 26, 2024
## 🤖 New release
* `near-workspaces`: 0.10.0 -> 0.10.1

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

##
[0.10.1](near-workspaces-v0.10.0...near-workspaces-v0.10.1)
- 2024-06-26

### Added
- Exposes status RPC API method
([#308](#308))
- Fixed `dev_deploy` to use registrar account to create top-level
accounts (nearcore 1.37.0+ forbidden to create top-level accounts by
non-registrar accounts)
([#360](#360))
- Re-exported near-abi-client
([#303](#303))

### Other
- a way to get account with more than 100 near on sandbox
([#351](#351))
- Updated cargo-near to "0.5.2"
([#347](#347))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants