Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: cleanup before release 0.2 #94

Merged
merged 14 commits into from
Mar 29, 2022
Merged

chore: cleanup before release 0.2 #94

merged 14 commits into from
Mar 29, 2022

Conversation

ChaoticTempest
Copy link
Member

Some cleanup before release 0.2:

  • Added testnet_archival and with_{mainnet, testnet}_archival functions
  • fixup readme, added M1 setup and added badges
  • updated and added more docs to functions
  • Added max_gas convenience function so we don't have to do .gas(300_ ...) anymore

austinabell
austinabell approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@austinabell austinabell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nits but love these docs additions/improvements :)

README.md Outdated Show resolved Hide resolved
workspaces/src/network/account.rs Outdated Show resolved Hide resolved
workspaces/src/network/transaction.rs Outdated Show resolved Hide resolved
ChaoticTempest and others added 3 commits March 28, 2022 18:51
@ChaoticTempest @austinabell
Update README.md
332eb76 
Co-authored-by: Austin Abell <austinabell8@gmail.com>
@ChaoticTempest @austinabell
Update workspaces/src/network/transaction.rs
b16b537 
Co-authored-by: Austin Abell <austinabell8@gmail.com>
@ChaoticTempest
Correct doc
e7e70d3
@ChaoticTempest ChaoticTempest changed the title Chore/cleanup chore: cleanup before release 0.2 Mar 29, 2022
austinabell
austinabell approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@austinabell austinabell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes lgtm

@ChaoticTempest ChaoticTempest merged commit 64bf467 into main Mar 29, 2022
@ChaoticTempest ChaoticTempest deleted the chore/cleanup branch March 29, 2022 17:25
@ChaoticTempest ChaoticTempest mentioned this pull request Mar 29, 2022
Merged
@frol frol mentioned this pull request Oct 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austinabell austinabell austinabell approved these changes

@itegulov itegulov itegulov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChaoticTempest @itegulov @austinabell