Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
bugfix: wasmtime: instantiating function type incompatibility (#12096)
Resolves: #12062 This PR resolves the issue with the wasmtime function type incompatibility. To understand the issue, I highly recommend my investigation comments on the issue itself: #12062 To be honest, I'm not sure it's a proper fix as I guess the root cause of the issue is somewhere outside of the file that leads to running under different engines/settings, leading to instantiating failures. It's a bit weird that the WasmtimeVM instance and Module instance could be different somehow as wasmtime::Engine is an arc wrapper. And module seems to clone it inside which should be still the same instance. I could reproduce the issue only by tweaking the code manually by recreating an engine before the linking. It means that something more complex happens and we need a test on that But this fix resolves an issue reported by #12062: https://github.com/near/near-workspaces-rs/actions/runs/10835958697/job/30200440749 CC @race-of-sloths
- Loading branch information