refactor: Migrate parameter configs to YAML (#8310)

This is a refactoring PR to enable #8264. For full motivation see #8264 (comment)

This PR only changes the disk format and parsing logic but doesn't change the in-memory representation, so it should not lead to any visible behaviour changes.

The next step in this refactoring would be to investigate getting rid of `serde_json::Value` in favor of `serde_yaml::Value` or even better a specialized struct with much more restricted types to catch invalid config errors earlier.

Cargo.toml

@@ -170,6 +170,7 @@ serde = { version = "1.0.136", features = ["alloc", "derive", "rc"] }
 serde_ignored = "0.1"
 serde_json = "1.0.68"
 serde_repr = "0.1.8"
+serde_yaml = "0.8.26"
 sha2 = "0.10"
 sha3 = "0.10"
 shell-escape = "0.1.5"

core/primitives/Cargo.toml

@@ -29,6 +29,7 @@ rand.workspace = true
 reed-solomon-erasure.workspace = true
 serde.workspace = true
 serde_json.workspace = true
+serde_yaml.workspace = true
 smart-default.workspace = true
 stdx.workspace = true
 strum.workspace = true

core/primitives/res/README.md

@@ -4,18 +4,18 @@ Stores resource data which is part of the protocol stable enough to be moved out
 
 ### `runtime_configs`
 
-All parameter value to configure the runtime are defined in `parameters.txt`.
+All parameter value to configure the runtime are defined in `parameters.yaml`.
 Parameters added or changed in protocol upgrades are defined in differential
-config files with a naming scheme like `V.txt`, where `V` is the new version.
+config files with a naming scheme like `V.yaml`, where `V` is the new version.
 
 The content of the base configuration file is one flat list of typed keys and
 untyped values. Key names are defined in
 `core/primitives-core/src/parameter.rs`.
 
 The format of the differential files is slightly different. Inserting new
-parameters uses the same syntax as the base configuration file: `key: value`.
-Parameters that change are specified like this: `key: old_value -> new_value`.
+parameters uses the following syntax: `key: { new: value }`.
+Parameters that change are specified like this: `key: { old: old_value, new: new_value }`.
 Removing a previously defined parameter for a new version is done as follows: 
-`key: old_value ->`. This causes the parameter value to be undefined in newer
+`key: { old: old_value }`. This causes the parameter value to be undefined in newer
 versions which generally means the default value is used to fill in the
 `RuntimeConfig` object.

core/primitives/res/runtime_configs/42.yaml

@@ -0,0 +1 @@
+storage_amount_per_byte: { old: 100_000_000_000_000_000_000, new: 10_000_000_000_000_000_000 }

core/primitives/res/runtime_configs/48.yaml

@@ -0,0 +1,8 @@
+wasm_regular_op_cost: { old: 3_856_371, new: 2_207_874 }
+wasm_ecrecover_base: { old: 3_365_369_625_000, new: 278_821_988_457 }
+data_receipt_creation_base_send_sir: { old: 4_697_339_419_375, new: 36_486_732_312 }
+data_receipt_creation_base_send_not_sir: { old: 4_697_339_419_375, new: 36_486_732_312 }
+data_receipt_creation_base_execution: { old: 4_697_339_419_375, new: 36_486_732_312 }
+data_receipt_creation_per_byte_send_sir: { old: 59_357_464, new: 17_212_011 }
+data_receipt_creation_per_byte_send_not_sir: { old: 59_357_464, new: 17_212_011 }
+data_receipt_creation_per_byte_execution: { old: 59_357_464, new: 17_212_011 }

core/primitives/res/runtime_configs/49.yaml

@@ -0,0 +1,2 @@
+wasm_regular_op_cost: { old: 2_207_874, new: 822_756 }
+max_functions_number_per_contract: { new: 10_000 }

core/primitives/res/runtime_configs/50.yaml

@@ -0,0 +1 @@
+stack_limiter_version: { old: 0, new: 1 }

core/primitives/res/runtime_configs/52.yaml

@@ -0,0 +1,2 @@
+max_gas_burnt: { old: 200_000_000_000_000, new: 300_000_000_000_000 }
+max_gas_burnt_view: { old: 200_000_000_000_000, new: 300_000_000_000_000 }

core/primitives/res/runtime_configs/53.yaml

@@ -0,0 +1,4 @@
+action_deploy_contract_per_byte_execution: { old: 6_812_999, new: 64_572_944 }
+wasmer2_stack_limit: { new: 204_800 }
+max_length_storage_key: { old: 4_194_304, new: 2_048 }
+max_locals_per_contract: { new: 1_000_000 }

core/primitives/res/runtime_configs/57.yaml

@@ -0,0 +1 @@
+account_id_validity_rules_version: { old: 0, new: 1 }

core/primitives/res/runtime_configs/parameters.txt → core/primitives/res/runtime_configs/parameters.yaml

@@ -10,7 +10,7 @@ pessimistic_gas_price_inflation_denominator: 100
 
 # Account creation config
 min_allowed_top_level_account_length: 32
-registrar_account_id: registrar
+registrar_account_id: "registrar"
 
 # Storage usage config
 storage_amount_per_byte: 100_000_000_000_000_000_000
@@ -156,5 +156,4 @@ max_length_storage_key: 4_194_304
 max_length_storage_value: 4_194_304
 max_promises_per_function_call_action: 1_024
 max_number_input_data_dependencies: 128
-stack_limiter_version: 0
 account_id_validity_rules_version: 0

core/primitives/res/runtime_configs/parameters_testnet.txt → core/primitives/res/runtime_configs/parameters_testnet.yaml

@@ -6,7 +6,7 @@ pessimistic_gas_price_inflation_denominator: 100
 
 # Account creation config
 min_allowed_top_level_account_length: 0
-registrar_account_id: registrar
+registrar_account_id: "registrar"
 
 # Storage usage config
 storage_amount_per_byte: 100_000_000_000_000_000_000

core/primitives/src/runtime/config_store.rs

@@ -13,25 +13,25 @@ macro_rules! include_config {
 
 /// The base config file with all initial parameter values defined.
 /// Later version are calculated by applying diffs to this base.
-static BASE_CONFIG: &str = include_config!("parameters.txt");
+static BASE_CONFIG: &str = include_config!("parameters.yaml");
 
 /// Stores pairs of protocol versions for which runtime config was updated and
 /// the file containing the diffs in bytes.
 static CONFIG_DIFFS: &[(ProtocolVersion, &str)] = &[
-    (42, include_config!("42.txt")),
-    (48, include_config!("48.txt")),
-    (49, include_config!("49.txt")),
-    (50, include_config!("50.txt")),
+    (42, include_config!("42.yaml")),
+    (48, include_config!("48.yaml")),
+    (49, include_config!("49.yaml")),
+    (50, include_config!("50.yaml")),
     // max_gas_burnt increased to 300 TGas
-    (52, include_config!("52.txt")),
+    (52, include_config!("52.yaml")),
     // Increased deployment costs, increased wasmer2 stack_limit, added limiting of contract locals,
     // set read_cached_trie_node cost, decrease storage key limit
-    (53, include_config!("53.txt")),
-    (57, include_config!("57.txt")),
+    (53, include_config!("53.yaml")),
+    (57, include_config!("57.yaml")),
 ];
 
 /// Testnet parameters for versions <= 29, which (incorrectly) differed from mainnet parameters
-pub static INITIAL_TESTNET_CONFIG: &str = include_config!("parameters_testnet.txt");
+pub static INITIAL_TESTNET_CONFIG: &str = include_config!("parameters_testnet.yaml");
 
 /// Stores runtime config for each protocol version where it was updated.
 #[derive(Debug)]