[stateless_validation] Add a soft size limit for state witness (#10703)

This PR adds a new runtime config `state_witness_size_soft_limit` with size about 16 MB to begin with along with an implementation to enforce it in runtime. This is the first step of #10259 What is state witness size soft limit? In order to limit the size of the state witness, as a first step, we are adding a limit to the max size of the state witness partial trie or proof. In runtime, we record all the trie nodes touched by the chunk execution and include these in the state witness. With the limit in place, if the size of the state witness exceeds 16 MB, then we would stop applying receipts further and push all receipts into the delayed queue. The reason we call this a soft limit is that we stop the execution of the receipts AFTER the size of the state witness has exceeded 16 MB. We are including this as part of a new protocol version 83 Future steps - Introduce limits on other parts of the state witness like new transactions - Introduce a hard size limit for individual contract executions - Monitor size of state witness - Add metrics in a separate PR
near · Mar 7, 2024 · 8e0bdf3 · 8e0bdf3
1 parent d50e30c
commit 8e0bdf3
Show file tree

Hide file tree

Showing 57 changed files with 686 additions and 64 deletions.
diff --git a/core/parameters/res/runtime_configs/83.yaml b/core/parameters/res/runtime_configs/83.yaml
@@ -0,0 +1 @@
+storage_proof_size_soft_limit: {old: 999_999_999_999_999, new: 16_000_000}
diff --git a/core/parameters/res/runtime_configs/parameters.snap b/core/parameters/res/runtime_configs/parameters.snap
@@ -4,6 +4,7 @@ description: THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.
 ---
 burnt_gas_reward                        3 / 10
 pessimistic_gas_price_inflation         103 / 100
+storage_proof_size_soft_limit            999_999_999_999_999
 min_allowed_top_level_account_length                      65
 registrar_account_id                    registrar
 storage_amount_per_byte                 10000000000000000000
@@ -180,4 +181,3 @@ function_call_weight                    true
 vm_kind                                 NearVm
 eth_implicit_accounts                   false
 yield_resume                            false
-
diff --git a/core/parameters/res/runtime_configs/parameters.yaml b/core/parameters/res/runtime_configs/parameters.yaml
@@ -12,6 +12,9 @@ pessimistic_gas_price_inflation: {
   denominator: 100,
 }
 
+# Stateless validation config
+storage_proof_size_soft_limit: 999_999_999_999_999
+
 # Account creation config
 min_allowed_top_level_account_length: 32
 registrar_account_id: "registrar"

diff --git a/core/parameters/res/runtime_configs/parameters_testnet.yaml b/core/parameters/res/runtime_configs/parameters_testnet.yaml
@@ -8,6 +8,9 @@ pessimistic_gas_price_inflation: {
   denominator: 100,
 }
 
+# Stateless validation config
+storage_proof_size_soft_limit: 999_999_999_999_999
+
 # Account creation config
 min_allowed_top_level_account_length: 0
 registrar_account_id: "registrar"

diff --git a/core/parameters/src/config.rs b/core/parameters/src/config.rs
@@ -23,6 +23,8 @@ pub struct RuntimeConfig {
     pub wasm_config: crate::vm::Config,
     /// Config that defines rules for account creation.
     pub account_creation_config: AccountCreationConfig,
+    /// The maximum size of the storage proof in state witness after which we defer execution of any new receipts.
+    pub storage_proof_size_soft_limit: usize,
 }
 
 impl RuntimeConfig {
@@ -45,6 +47,7 @@ impl RuntimeConfig {
             fees: RuntimeFeesConfig::test(),
             wasm_config,
             account_creation_config: AccountCreationConfig::default(),
+            storage_proof_size_soft_limit: usize::MAX,
         }
     }
 
@@ -57,6 +60,7 @@ impl RuntimeConfig {
             fees: RuntimeFeesConfig::free(),
             wasm_config,
             account_creation_config: AccountCreationConfig::default(),
+            storage_proof_size_soft_limit: usize::MAX,
         }
     }
 

diff --git a/core/parameters/src/config_store.rs b/core/parameters/src/config_store.rs
@@ -37,6 +37,7 @@ static CONFIG_DIFFS: &[(ProtocolVersion, &str)] = &[
     (62, include_config!("62.yaml")),
     (63, include_config!("63.yaml")),
     (64, include_config!("64.yaml")),
+    (83, include_config!("83.yaml")),
     (129, include_config!("129.yaml")),
     // Introduce ETH-implicit accounts.
     (138, include_config!("138.yaml")),
@@ -317,6 +318,7 @@ mod tests {
     /// the new snapshot if it looks right.
     #[test]
     #[cfg(not(feature = "nightly"))]
+    #[cfg(not(feature = "statelessnet_protocol"))]
     #[cfg(not(feature = "calimero_zero_storage"))]
     fn test_json_unchanged() {
         use crate::view::RuntimeConfigView;

diff --git a/core/parameters/src/parameter.rs b/core/parameters/src/parameter.rs
@@ -20,6 +20,9 @@ pub enum Parameter {
     BurntGasReward,
     PessimisticGasPriceInflation,
 
+    // Stateless validation config
+    StorageProofSizeSoftLimit,
+
     // Account creation config
     MinAllowedTopLevelAccountLength,
     RegistrarAccountId,

diff --git a/core/parameters/src/parameter_table.rs b/core/parameters/src/parameter_table.rs
@@ -332,6 +332,7 @@ impl TryFrom<&ParameterTable> for RuntimeConfig {
                     .get(Parameter::MinAllowedTopLevelAccountLength)?,
                 registrar_account_id: params.get(Parameter::RegistrarAccountId)?,
             },
+            storage_proof_size_soft_limit: params.get(Parameter::StorageProofSizeSoftLimit)?,
         })
     }
 }

diff --git a/core/parameters/src/snapshots/near_parameters__config_store__tests__0.json.snap b/core/parameters/src/snapshots/near_parameters__config_store__tests__0.json.snap
@@ -102,7 +102,8 @@ expression: config_view
     "pessimistic_gas_price_inflation_ratio": [
       103,
       100
-    ]
+    ],
+    "storage_proof_size_soft_limit": 999999999999999
   },
   "wasm_config": {
     "ext_costs": {

diff --git a/core/parameters/src/snapshots/near_parameters__config_store__tests__129.json.snap b/core/parameters/src/snapshots/near_parameters__config_store__tests__129.json.snap
@@ -102,7 +102,8 @@ expression: config_view
     "pessimistic_gas_price_inflation_ratio": [
       103,
       100
-    ]
+    ],
+    "storage_proof_size_soft_limit": 16000000
   },
   "wasm_config": {
     "ext_costs": {

diff --git a/core/parameters/src/snapshots/near_parameters__config_store__tests__138.json.snap b/core/parameters/src/snapshots/near_parameters__config_store__tests__138.json.snap
@@ -102,7 +102,8 @@ expression: config_view
     "pessimistic_gas_price_inflation_ratio": [
       103,
       100
-    ]
+    ],
+    "storage_proof_size_soft_limit": 16000000
   },
   "wasm_config": {
     "ext_costs": {

diff --git a/core/parameters/src/snapshots/near_parameters__config_store__tests__139.json.snap b/core/parameters/src/snapshots/near_parameters__config_store__tests__139.json.snap
@@ -102,7 +102,8 @@ expression: config_view
     "pessimistic_gas_price_inflation_ratio": [
       103,
       100
-    ]
+    ],
+    "storage_proof_size_soft_limit": 16000000
   },
   "wasm_config": {
     "ext_costs": {

diff --git a/core/parameters/src/snapshots/near_parameters__config_store__tests__35.json.snap b/core/parameters/src/snapshots/near_parameters__config_store__tests__35.json.snap
@@ -102,7 +102,8 @@ expression: config_view
     "pessimistic_gas_price_inflation_ratio": [
       103,
       100
-    ]
+    ],
+    "storage_proof_size_soft_limit": 999999999999999
   },
   "wasm_config": {
     "ext_costs": {

diff --git a/core/parameters/src/snapshots/near_parameters__config_store__tests__42.json.snap b/core/parameters/src/snapshots/near_parameters__config_store__tests__42.json.snap
@@ -102,7 +102,8 @@ expression: config_view
     "pessimistic_gas_price_inflation_ratio": [
       103,
       100
-    ]
+    ],
+    "storage_proof_size_soft_limit": 999999999999999
   },
   "wasm_config": {
     "ext_costs": {

diff --git a/core/parameters/src/snapshots/near_parameters__config_store__tests__46.json.snap b/core/parameters/src/snapshots/near_parameters__config_store__tests__46.json.snap
@@ -102,7 +102,8 @@ expression: config_view
     "pessimistic_gas_price_inflation_ratio": [
       103,
       100
-    ]
+    ],
+    "storage_proof_size_soft_limit": 999999999999999
   },
   "wasm_config": {
     "ext_costs": {

diff --git a/core/parameters/src/snapshots/near_parameters__config_store__tests__48.json.snap b/core/parameters/src/snapshots/near_parameters__config_store__tests__48.json.snap
@@ -102,7 +102,8 @@ expression: config_view
     "pessimistic_gas_price_inflation_ratio": [
       103,
       100
-    ]
+    ],
+    "storage_proof_size_soft_limit": 999999999999999
   },
   "wasm_config": {
     "ext_costs": {

diff --git a/core/parameters/src/snapshots/near_parameters__config_store__tests__49.json.snap b/core/parameters/src/snapshots/near_parameters__config_store__tests__49.json.snap
@@ -102,7 +102,8 @@ expression: config_view
     "pessimistic_gas_price_inflation_ratio": [
       103,
       100
-    ]
+    ],
+    "storage_proof_size_soft_limit": 999999999999999
   },
   "wasm_config": {
     "ext_costs": {

diff --git a/core/parameters/src/snapshots/near_parameters__config_store__tests__50.json.snap b/core/parameters/src/snapshots/near_parameters__config_store__tests__50.json.snap
@@ -102,7 +102,8 @@ expression: config_view
     "pessimistic_gas_price_inflation_ratio": [
       103,
       100
-    ]
+    ],
+    "storage_proof_size_soft_limit": 999999999999999
   },
   "wasm_config": {
     "ext_costs": {

diff --git a/core/parameters/src/snapshots/near_parameters__config_store__tests__52.json.snap b/core/parameters/src/snapshots/near_parameters__config_store__tests__52.json.snap
@@ -102,7 +102,8 @@ expression: config_view
     "pessimistic_gas_price_inflation_ratio": [
       103,
       100
-    ]
+    ],
+    "storage_proof_size_soft_limit": 999999999999999
   },
   "wasm_config": {
     "ext_costs": {

diff --git a/core/parameters/src/snapshots/near_parameters__config_store__tests__53.json.snap b/core/parameters/src/snapshots/near_parameters__config_store__tests__53.json.snap
@@ -102,7 +102,8 @@ expression: config_view
     "pessimistic_gas_price_inflation_ratio": [
       103,
       100
-    ]
+    ],
+    "storage_proof_size_soft_limit": 999999999999999
   },
   "wasm_config": {
     "ext_costs": {

diff --git a/core/parameters/src/snapshots/near_parameters__config_store__tests__55.json.snap b/core/parameters/src/snapshots/near_parameters__config_store__tests__55.json.snap
@@ -102,7 +102,8 @@ expression: config_view
     "pessimistic_gas_price_inflation_ratio": [
       103,
       100
-    ]
+    ],
+    "storage_proof_size_soft_limit": 999999999999999
   },
   "wasm_config": {
     "ext_costs": {

diff --git a/core/parameters/src/snapshots/near_parameters__config_store__tests__57.json.snap b/core/parameters/src/snapshots/near_parameters__config_store__tests__57.json.snap
@@ -102,7 +102,8 @@ expression: config_view
     "pessimistic_gas_price_inflation_ratio": [
       103,
       100
-    ]
+    ],
+    "storage_proof_size_soft_limit": 999999999999999
   },
   "wasm_config": {
     "ext_costs": {

diff --git a/core/parameters/src/snapshots/near_parameters__config_store__tests__59.json.snap b/core/parameters/src/snapshots/near_parameters__config_store__tests__59.json.snap
@@ -102,7 +102,8 @@ expression: config_view
     "pessimistic_gas_price_inflation_ratio": [
       103,
       100
-    ]
+    ],
+    "storage_proof_size_soft_limit": 999999999999999
   },
   "wasm_config": {
     "ext_costs": {

diff --git a/core/parameters/src/snapshots/near_parameters__config_store__tests__61.json.snap b/core/parameters/src/snapshots/near_parameters__config_store__tests__61.json.snap
@@ -102,7 +102,8 @@ expression: config_view
     "pessimistic_gas_price_inflation_ratio": [
       103,
       100
-    ]
+    ],
+    "storage_proof_size_soft_limit": 999999999999999
   },
   "wasm_config": {
     "ext_costs": {

diff --git a/core/parameters/src/snapshots/near_parameters__config_store__tests__62.json.snap b/core/parameters/src/snapshots/near_parameters__config_store__tests__62.json.snap
@@ -102,7 +102,8 @@ expression: config_view
     "pessimistic_gas_price_inflation_ratio": [
       103,
       100
-    ]
+    ],
+    "storage_proof_size_soft_limit": 999999999999999
   },
   "wasm_config": {
     "ext_costs": {

diff --git a/core/parameters/src/snapshots/near_parameters__config_store__tests__63.json.snap b/core/parameters/src/snapshots/near_parameters__config_store__tests__63.json.snap
@@ -102,7 +102,8 @@ expression: config_view
     "pessimistic_gas_price_inflation_ratio": [
       103,
       100
-    ]
+    ],
+    "storage_proof_size_soft_limit": 999999999999999
   },
   "wasm_config": {
     "ext_costs": {

diff --git a/core/parameters/src/snapshots/near_parameters__config_store__tests__64.json.snap b/core/parameters/src/snapshots/near_parameters__config_store__tests__64.json.snap
@@ -102,7 +102,8 @@ expression: config_view
     "pessimistic_gas_price_inflation_ratio": [
       103,
       100
-    ]
+    ],
+    "storage_proof_size_soft_limit": 999999999999999
   },
   "wasm_config": {
     "ext_costs": {
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		storage_proof_size_soft_limit: {old: 999_999_999_999_999, new: 16_000_000}
-Original file line number
+Diff line change
@@ Expand Up / @@ -332,6 +332,7 @@ impl TryFrom<&ParameterTable> for RuntimeConfig { @@
                         .get(Parameter::MinAllowedTopLevelAccountLength)?,
                     registrar_account_id: params.get(Parameter::RegistrarAccountId)?,
                 },
+                storage_proof_size_soft_limit: params.get(Parameter::StorageProofSizeSoftLimit)?,
             })
         }
     }
@@ Expand Down @@