Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split gas_limit #1700

Open
Tracked by #8877
MaksymZavershynskyi opened this issue Nov 15, 2019 · 10 comments
Open
Tracked by #8877

Split gas_limit #1700

MaksymZavershynskyi opened this issue Nov 15, 2019 · 10 comments
Labels
A-congestion Work aimed at ensuring good system performance under congestion A-transaction-runtime Area: transaction runtime (transaction and receipts processing, state transition, etc) S-blocked Status: blocked T-core Team: issues relevant to the core team

Comments

@MaksymZavershynskyi
Copy link
Contributor

We need to split gas_limit into transaction_gas_limit and receipt_gas_limit, instead of dividing gas_limit by 2, because 2 is a magic number which should avoid from having in our protocol.

@MaksymZavershynskyi MaksymZavershynskyi changed the title [Economics] Split gas_limit Split gas_limit Nov 19, 2019
@MaksymZavershynskyi MaksymZavershynskyi added the A-transaction-runtime Area: transaction runtime (transaction and receipts processing, state transition, etc) label Nov 19, 2019
@ilblackdragon ilblackdragon added this to the MainNet milestone Dec 8, 2019
@evgenykuzyakov
Copy link
Collaborator

Blocked on discussion about shard congestion, because the current split might be deprecated based on the result of the discussion

@MaksymZavershynskyi
Copy link
Contributor Author

@evgenykuzyakov to follow up with discussion on how this should be done.

@evgenykuzyakov
Copy link
Collaborator

Blocked by #2196

@evgenykuzyakov
Copy link
Collaborator

Blocked on new Economics. It's still unclear how gas price should be determined.

@MaksymZavershynskyi
Copy link
Contributor Author

MaksymZavershynskyi commented Mar 23, 2020

Since we are launching a single-sharded Mainnet, multi-sharded economics is not a priority for the Mainnet launch, and so we can keep the way it is currently done for now.

@ilblackdragon ilblackdragon removed this from the MainNet milestone Mar 24, 2020
@stale
Copy link

stale bot commented Jul 1, 2021

This issue has been automatically marked as stale because it has not had recent activity in the last 2 months.
It will be closed in 7 days if no further activity occurs.
Thank you for your contributions.

@stale stale bot added the S-stale label Jul 1, 2021
@stale stale bot removed the S-stale label Jul 2, 2021
@bowenwang1996 bowenwang1996 added S-blocked Status: blocked T-core Team: issues relevant to the core team labels Jul 2, 2021
@bowenwang1996
Copy link
Collaborator

We should take this into consideration while researching gas price auction. cc @abacabadabacaba

@aborg-dev aborg-dev added the A-congestion Work aimed at ensuring good system performance under congestion label May 31, 2023
@aborg-dev
Copy link
Contributor

aborg-dev commented May 31, 2023

We will be tackling this as a part of Local Congestion Control work. More specifically in #8877, the split will be based on the amount of space left in delayed receipts queue, going to 0 when there is no more space in the queue to add new receipts from the transaction pool.

@aborg-dev aborg-dev self-assigned this Jul 24, 2023
@jakmeier
Copy link
Contributor

We will be tackling this as a part of Local Congestion Control work.

@Akashin the work on local congestion control has concluded for now, right?
My understanding is we haven't really change the tx/receipt gas split, yet. But maybe we will change it in the future when working on global congestion control. Can you please confirm or deny?

@aborg-dev
Copy link
Contributor

aborg-dev commented Aug 31, 2023

We will be tackling this as a part of Local Congestion Control work.

@Akashin the work on local congestion control has concluded for now, right? My understanding is we haven't really change the tx/receipt gas split, yet. But maybe we will change it in the future when working on global congestion control. Can you please confirm or deny?

That's correct, I was initially planning to change this part but couldn't do it because we don't store information about the total attached gas of the delayed receipts in an easily consumable format (right now, we would need to compute it by iterating over all delayed receipts). So for now the limit is just based on the number of delayed receipts, but for global congestion control we would need to store the aggregated attached gas in the chunks anyway and so implementing the feature I've described in #1700 (comment) would become easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-congestion Work aimed at ensuring good system performance under congestion A-transaction-runtime Area: transaction runtime (transaction and receipts processing, state transition, etc) S-blocked Status: blocked T-core Team: issues relevant to the core team
Projects
None yet
Development

No branches or pull requests

6 participants