-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split gas_limit #1700
Comments
Blocked on discussion about shard congestion, because the current split might be deprecated based on the result of the discussion |
@evgenykuzyakov to follow up with discussion on how this should be done. |
Blocked by #2196 |
Blocked on new Economics. It's still unclear how gas price should be determined. |
Since we are launching a single-sharded Mainnet, multi-sharded economics is not a priority for the Mainnet launch, and so we can keep the way it is currently done for now. |
This issue has been automatically marked as stale because it has not had recent activity in the last 2 months. |
We should take this into consideration while researching gas price auction. cc @abacabadabacaba |
We will be tackling this as a part of Local Congestion Control work. More specifically in #8877, the split will be based on the amount of space left in delayed receipts queue, going to 0 when there is no more space in the queue to add new receipts from the transaction pool. |
@Akashin the work on local congestion control has concluded for now, right? |
That's correct, I was initially planning to change this part but couldn't do it because we don't store information about the total attached gas of the delayed receipts in an easily consumable format (right now, we would need to compute it by iterating over all delayed receipts). So for now the limit is just based on the number of delayed receipts, but for global congestion control we would need to store the aggregated attached gas in the chunks anyway and so implementing the feature I've described in #1700 (comment) would become easier. |
We need to split
gas_limit
intotransaction_gas_limit
andreceipt_gas_limit
, instead of dividinggas_limit
by2
, because2
is a magic number which should avoid from having in our protocol.The text was updated successfully, but these errors were encountered: