feat: statelessnet protocol #10518
Merged
feat: statelessnet protocol #10518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 29, 2024 16:17
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #10518 +/- ##
==========================================
- Coverage 72.00% 71.99% -0.01%
==========================================
Files 720 720
Lines 146558 146559 +1
Branches 146558 146559 +1
==========================================
- Hits 105531 105520 -11
- Misses 36158 36175 +17
+ Partials 4869 4864 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wacban
approved these changes
Jan 29, 2024
core/store/src/opener.rs
Outdated
Comment on lines
451
to
455
| if cfg!(feature = "nightly") | ||
| || cfg!(feature = "nightly_protocol") | ||
| || cfg!(feature = "statelessnet_protocol") | ||
| { | ||
| let version = 10000; |
There was a problem hiding this comment.
I'm afraid to ask what is going on here.
There was a problem hiding this comment.
From what I saw here, DB version is set to smth large if protocol is not stable.
Actually, now I'm not sure why this is needed at all. We may want to upgrade DB on master and then we'll want to see stateless nodes upgraded as well. So I'm removing this for statelessnet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set special protocol feature and version to launch near/near-one-project-tracking#20 against.