test: statelessnet ci #10589
test: statelessnet ci #10589
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10589 +/- ##
==========================================
+ Coverage 72.00% 72.02% +0.01%
==========================================
Files 724 724
Lines 147205 147205
Branches 147205 147205
==========================================
+ Hits 105994 106021 +27
+ Misses 36359 36336 -23
+ Partials 4852 4848 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@nagisa because Leo is OOO, could you double-check this please? |
| @@ -116,6 +116,7 @@ nightly_protocol = [ | |||
| "nearcore/nightly_protocol", | |||
| ] | |||
| statelessnet_protocol = [ | |||
| "nearcore/statelessnet_protocol", | |||
There was a problem hiding this comment.
Is having this compile-time feature temporary? I feel like we should definitely look at making this a runtime flag if possible to avoid a matrix of 3 distinct neards if possible. It already is hard as-is to keep up with two configurations during regular development.
There was a problem hiding this comment.
Yeah, it will be removed after StatelessNet is complete (2 months?).
This protocol feature is needed to enforce specific protocol version everywhere, including tests. I doubt that passing protocol version to all involved structures is more practical than just have PROTOCOL_VERSION checks.
Introduce automatic CI checks for latest statelessnet binary used for near/near-one-project-tracking#20. This PR adopts new check automatically.
The check is not required, in order not to block main development flow.
Wanted to make this trigger only on demand, but there is no simple way to do it.