fix(test) - fix flaky test #11508
Merged
fix(test) - fix flaky test #11508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakmeier
approved these changes
Jun 6, 2024
| @@ -203,7 +203,7 @@ impl CongestionControlConfig { | |||
| allowed_shard_outgoing_gas: max_value, | |||
| max_tx_gas: max_value, | |||
| min_tx_gas: max_value, | |||
| reject_tx_congestion_threshold: 1.0, | |||
| reject_tx_congestion_threshold: 2.0, | |||
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11508 +/- ##
=======================================
Coverage 71.31% 71.31%
=======================================
Files 787 787
Lines 159389 159391 +2
Branches 159389 159391 +2
=======================================
+ Hits 113661 113671 +10
+ Misses 40789 40782 -7
+ Partials 4939 4938 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
it turns out that the config wasn't actually passed in to the runtime and I was unlucky when testing it.. |
jakmeier
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
test_in_memory_trie_node_consistencywas failing occasionally because the config with disabled congestion control wasn't properly passed into the nightshade runtime. Also setting the threshold for rejecting transactions from 1 to 2 because otherwise some could still get rejected under full congestion.