Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fees for transactions, receipts, actions. #1176

Merged
merged 9 commits into from
Aug 16, 2019
Merged

Fees for transactions, receipts, actions. #1176

merged 9 commits into from
Aug 16, 2019

Conversation

MaksymZavershynskyi
Copy link
Contributor

No description provided.

evgenykuzyakov
evgenykuzyakov requested changes Aug 16, 2019
View reviewed changes
Copy link
Collaborator

@evgenykuzyakov evgenykuzyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done.

Needs 2 changes:

  • for access keys need to add cost per bytes
  • we shouldn't charge send fee for function_call actions in the middle of the batch.

runtime/near-runtime-fees/src/lib.rs Outdated Show resolved Hide resolved
runtime/near-runtime-fees/src/lib.rs Outdated Show resolved Hide resolved
runtime/near-runtime-fees/src/lib.rs Show resolved Hide resolved
runtime/near-vm-logic/src/context.rs Outdated Show resolved Hide resolved
runtime/runtime/src/lib.rs Outdated Show resolved Hide resolved
runtime/runtime/src/actions.rs Outdated Show resolved Hide resolved
@evgenykuzyakov
Copy link
Collaborator

evgenykuzyakov commented Aug 16, 2019 •
edited
Loading

Also not sure why test_access_key_smart_contract_runtime didn't fail. Oh I guess most tests fail now

bowenwang1996
bowenwang1996 reviewed Aug 16, 2019
View reviewed changes
Cargo.toml Show resolved Hide resolved
runtime/near-vm-logic/src/logic.rs Outdated Show resolved Hide resolved
@weekly-digest weekly-digest bot mentioned this pull request Aug 16, 2019
Closed
evgenykuzyakov
evgenykuzyakov approved these changes Aug 16, 2019
View reviewed changes
runtime/near-runtime-fees/src/lib.rs Outdated Show resolved Hide resolved
runtime/runtime/src/config.rs Outdated Show resolved Hide resolved
@MaksymZavershynskyi MaksymZavershynskyi merged commit 68a7fda into staging Aug 16, 2019
@MaksymZavershynskyi MaksymZavershynskyi deleted the transaction_fees branch August 16, 2019 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowenwang1996 bowenwang1996 bowenwang1996 left review comments

@evgenykuzyakov evgenykuzyakov evgenykuzyakov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MaksymZavershynskyi @evgenykuzyakov @bowenwang1996 @coqbot