Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark sync nodes tests as expensive #1199

Closed
wants to merge 1 commit into from
Closed

Mark sync nodes tests as expensive #1199

wants to merge 1 commit into from

Conversation

evgenykuzyakov
Copy link
Collaborator

One of the tests keeps failing on my laptop. Probably because of something happening in async across tests.

@MaksymZavershynskyi
Copy link
Contributor

This just ignores them. Use #[cfg(feature = "expensive_tests")] instead.

@bowenwang1996
Copy link
Collaborator

I cannot reproduce.

@weekly-digest weekly-digest bot mentioned this pull request Aug 23, 2019
Closed
@evgenykuzyakov
Copy link
Collaborator Author

Not relevant

@evgenykuzyakov evgenykuzyakov deleted the make-sync-nodes-tests-expensive branch September 5, 2019 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowenwang1996 bowenwang1996 Awaiting requested review from bowenwang1996

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evgenykuzyakov @MaksymZavershynskyi @bowenwang1996