fix(runtime) DeleteAccount action must be the last action #2829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lexfrl
requested review from
bowenwang1996,
evgenykuzyakov,
frol,
MaksymZavershynskyi and
SkidanovAlex
as code owners
|
|
lexfrl
force-pushed
the
fckt/delete-last-action
branch
from
344820b to
8eb3437
Compare
lexfrl
force-pushed
the
fckt/delete-last-action
branch
from
8eb3437 to
1dcda25
Compare
evgenykuzyakov
approved these changes
Jun 10, 2020
frol
approved these changes
Jun 10, 2020
Co-authored-by: Vlad Frolov <frolvlad@gmail.com>
lexfrl
force-pushed
the
fckt/delete-last-action
branch
from
cf25f32 to
a3ffe63
Compare
@bowenwang1996 |
lexfrl
changed the title
|
@fckt I plan to remove need to update near-api-js for new error types: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to avoid dDos we disallow to have DeleteAccount to be not a last action in Receipt.
@vgrichina this contains a new rpc error type to handle
fixes #2599