Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Removing flakiness from staking tests #3150

Merged
merged 4 commits into from
Aug 12, 2020
Merged

fix: Removing flakiness from staking tests #3150

merged 4 commits into from
Aug 12, 2020

Commits on Aug 12, 2020

  1. fix: Removing flakiness from staking tests 

    The flakiness was primarily due to insufficient number of blocks between the epoch switch, and checking for the expected stakes. The epoch was switching at heights equal to 2 modulo 10, and the checks were executed at the same heights. Moreover, the height was retrieved from one node, but the checks were against the other.
Fixing it by extending the epoch by two blocks, and moving the checks two blocks ahead.

Also adding checks before sending the second set of stakes, it covers a situation when the latest stake during the current epoch is higher than the current stake (a situation the test was not previously testing).

Reducing the timeout to 6 minutes from 10 minutes. staking2.py, staking_repro1.py and staking_repro2.py mostly test the same things, so it is still 18 minutes of testing per run. All the failures in the observable past were occurring much earlier than during the first 6 minutes of the test (e.g. see failures here: http://nayduck.eastus.cloudapp.azure.com:3000/#/run/67).

Test plan:
----------
No failures in 150 runs:
http://nayduck.eastus.cloudapp.azure.com:3000/#/run/69
    @SkidanovAlex
    SkidanovAlex committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    92c0dfc View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix_staking_flakines

    @SkidanovAlex
    SkidanovAlex authored Aug 12, 2020
    Configuration menu
    Copy the full SHA
    5a4ecfe View commit details
    Browse the repository at this point in the history

  3. Fixing typo

    @SkidanovAlex
    SkidanovAlex committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    1ae746c View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into fix_staking_flakines

    @bowenwang1996
    bowenwang1996 authored Aug 12, 2020
    Configuration menu
    Copy the full SHA
    342da33 View commit details
    Browse the repository at this point in the history