Upgrade to OpenEthereum 2.6.2 #3542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…3506 This is the last release that nearcore can pull in without errors. Further upgrades will require code changes in near-evm-runner.
artob
added
C-enhancement
artob
requested review from
bowenwang1996,
evgenykuzyakov,
frol,
MaksymZavershynskyi and
SkidanovAlex
as code owners
frol
approved these changes
Oct 30, 2020
evgenykuzyakov
approved these changes
Oct 30, 2020
This was referenced Nov 3, 2020
evgenykuzyakov
pushed a commit
that referenced
this pull request
Nov 5, 2020
As the next step in #3506, and following up from #3542, upgrade OpenEthereum from [2.6.2](https://github.com/openethereum/openethereum/releases/tag/v2.6.2) (Aug 2019) to [2.6.8](https://github.com/openethereum/openethereum/releases/tag/v2.6.8) (Dec 2019), the last release in the 2.6.x series. This brings us up to par on the [Istanbul](https://eth.wiki/en/roadmap/istanbul) hard fork, which incorporated many EIPs, changing gas metering and adding a new precompile as well as two new opcodes: - [EIP-152: Add BLAKE2 compression function `F` precompile](https://eips.ethereum.org/EIPS/eip-152) - [EIP-1108: Reduce alt_bn128 precompile gas costs](https://eips.ethereum.org/EIPS/eip-1108) - [EIP-1344: ChainID opcode](https://eips.ethereum.org/EIPS/eip-1344) (includes a new opcode: `CHAINID`) - [EIP-1884: Repricing for trie-size-dependent opcodes](https://eips.ethereum.org/EIPS/eip-1884) (includes a new opcode: `SELFBALANCE`) - [EIP-2028: Transaction data gas cost reduction](https://eips.ethereum.org/EIPS/eip-2028) - [EIP-2200: Structured Definitions for Net Gas Metering](https://eips.ethereum.org/EIPS/eip-2200) This PR includes an implementation of the `CHAINID` opcode. (The `SELFBALANCE` opcode doesn't need anything from our runtime.) The upstream changelog for 2.6.8 is at: https://github.com/openethereum/openethereum/blob/v2.6.8/CHANGELOG.md The upstream diff from 2.6.2 to 2.6.8 is at: openethereum/openethereum@v2.6.2...v2.6.8
This was referenced Nov 6, 2020
evgenykuzyakov
pushed a commit
that referenced
this pull request
Nov 12, 2020
As the next step in #3506, and following up from #3542 and #3558, upgrade Parity Ethereum (now OpenEthereum) from [2.6.8] (Dec 2019) to [2.7.2] (Feb 2020), the last release in the 2.x series. This harmonizes our dependency graph with upstream, fixing numerous build errors from the upgrade and eliminating multiple versions of the same crates. This concerns the [bn], [ethabi], [ethabi-contract], [ethabi-derive], [ethereum-types], [keccak-hash], [primitive-types], and [uint] crates as well as their transitive dependencies and their interdependencies. The [near/bn] fork exists to upgrade [bn]'s [rand] dependency. That's necessary because of a particularly complex dependency issue (rust-random/rand#645) in old versions of rand. We will eliminate the fork going forward once upstream upgrades their dependency (I will open a pull request for them). The upstream changelog for 2.7.2 is at: https://github.com/openethereum/openethereum/blob/v2.7.2/CHANGELOG.md The upstream diff from 2.6.8 to 2.7.2 is at: openethereum/openethereum@v2.6.8...v2.7.2 [2.6.8]: https://github.com/openethereum/openethereum/releases/tag/v2.6.8 [2.7.2]: https://github.com/openethereum/openethereum/releases/tag/v2.7.2 [near/bn]: https://github.com/near/bn [bn]: https://crates.io/crates/bn [ethabi]: https://crates.io/crates/ethabi [ethabi-contract]: https://crates.io/crates/ethabi-contract [ethabi-derive]: https://crates.io/crates/ethabi-derive [ethereum-types]: https://crates.io/crates/ethereum-types [keccak-hash]: https://crates.io/crates/keccak-hash [primitive-types]: https://crates.io/crates/primitive-types [rand]: https://crates.io/crates/rand [uint]: https://crates.io/crates/uint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a first step in #3506, upgrade OpenEthereum from pre-2.6.0 (Jun 2019) to 2.6.2 (Aug 2019).
OpenEthereum 2.6.2 is the last release that nearcore can currently pull in without build errors. Further upgrades will require code changes in near-evm-runner. (I'm working on those.)
The upstream diff from what we currently pull in compared to 2.6.2: openethereum/openethereum@eed630a...v2.6.2