feat(runtime): Wasmer 1.0 runner #3799
Conversation
ailisp
requested review from
bowenwang1996,
evgenykuzyakov,
frol and
SkidanovAlex
as code owners
| let func = info.functions.get(index.clone()).unwrap(); | ||
| let sig = info.signatures.get(func.clone()).unwrap(); |
There was a problem hiding this comment.
Is unwrap safe here?
There was a problem hiding this comment.
Still not answered
There was a problem hiding this comment.
It is safe, this function is almost identical to wasmer_runner::check_method, just wasmer_runtime_core::module::ExportIndex::Func => wasmer_types::ExportIndex::Function refactor done by wasmer. as i checked wasmer code, when Function(index) is in module.info().exports, corresponding index always exist in info.functions, say it is func, and func is always in info.signatures
| @@ -306,6 +314,19 @@ impl From<PrepareError> for VMError { | |||
| } | |||
| } | |||
|
|
|||
| impl From<&VMLogicError> for VMError { | |||
There was a problem hiding this comment.
nit: why we use &VMLogicError instead of VMLogicError?
There was a problem hiding this comment.
There're two calls this with e.into(), one e is a &VMLogicError, another is VMLogicError, so make a From<&VMLogicError> works for both
| let func = info.functions.get(index.clone()).unwrap(); | ||
| let sig = info.signatures.get(func.clone()).unwrap(); |
There was a problem hiding this comment.
Still not answered
Add Wasmer 1.0 runner, enabled by wasmer1_vm features (similar to wasmtime_vm). Expose wasmer 1.0 runner and wasmtime runner available to neard and vm standalone.
Test Plan
All near-vm-runner tests pass. compatible behavior as wasmer 0.17. neard compiles and work with wasmer 1.0 runner turns on