Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bring costs.txt inline with the actual protocol costs #5083

Closed
wants to merge 2 commits into from

Conversation

matklad
Copy link
Contributor

@matklad matklad commented Oct 26, 2021

forgot to do this in #4979

This doesn't affect any logic anywhere, just makes it easier to figure
out what our measured costs are.

forgot to do this in near#4979

This doesn't affect any logic anywhere, just makes it easier to figure
out what our measured costs are.
@matklad matklad requested a review from olonho as a code owner October 26, 2021 11:55
@matklad
Copy link
Contributor Author

matklad commented Oct 26, 2021

CI failure seems unrelated:



[2021-10-26T12:12:03Z]
--
  | [2021-10-26T12:12:03Z] failures:
  | [2021-10-26T12:12:03Z]
  | [2021-10-26T12:12:03Z] ---- trie::split_state::tests::test_get_trie_items_for_part stdout ----
  | [2021-10-26T12:12:03Z] thread 'trie::split_state::tests::test_get_trie_items_for_part' panicked at 'part length 1 avg length 0', core/store/src/trie/split_state.rs:451:13
  | [2021-10-26T12:12:03Z] note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
  | [2021-10-26T12:12:03Z]
  | [2021-10-26T12:12:03Z]
  | [2021-10-26T12:12:03Z] failures:
  | [2021-10-26T12:12:03Z]     trie::split_state::tests::test_get_trie_items_for_part

(cc @mzhangmzz ? split-state seems sharding related)

@stale
Copy link

stale bot commented Nov 9, 2021

This PR has been automatically marked as stale because it has not had recent activity in the 2 weeks.
It will be closed in 3 days if no further activity occurs.
Thank you for your contributions.

@stale stale bot added the S-stale label Nov 9, 2021
@mzhangmzz
Copy link
Contributor

sorry I just saw this. @matklad that test was flaky but I fixed it. It should work if you merge with the latest master

@stale stale bot removed the S-stale label Nov 9, 2021
@stale
Copy link

stale bot commented Nov 23, 2021

This PR has been automatically marked as stale because it has not had recent activity in the 2 weeks.
It will be closed in 3 days if no further activity occurs.
Thank you for your contributions.

@stale stale bot added the S-stale label Nov 23, 2021
@matklad
Copy link
Contributor Author

matklad commented May 20, 2022

Hopelessly obsolete, but let me tag @jakmeier here :)

The idea was that we need an easy reference for what the costs are today.

@matklad matklad closed this May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants