Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer lazy_static_include_bytes in tests #6654

Merged
merged 2 commits into from
Apr 21, 2022
Merged

Conversation

mina86
Copy link
Contributor

@mina86 mina86 commented Apr 20, 2022

Apparently lazy_static_include_bytes compiles faster than include_bytes
and we’re already using it in bunch of tests so do that consistently.

Apparently lazy_static_include_bytes compiles faster than include_bytes
and we’re already using it in bunch of tests so do that consistently.
@mina86 mina86 added P-low Priority: low S-automerge labels Apr 20, 2022
@mina86 mina86 requested a review from a team as a code owner April 20, 2022 22:50
@mina86 mina86 requested a review from nagisa April 20, 2022 22:50
Copy link
Contributor

@matklad matklad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an improvement! Though, I'd just std::fs::read in tests, to avoid using what we don't need (namely, for tests it's irrelevant that in --release this turns out into include!. It's actually slightly harmful, as we care about build time of cargo test --release a bit as well)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-low Priority: low
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants