feat: enable backtraces by default #7562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matklad
force-pushed
the
m/force-backtrace
branch
from
fc97b9b
to
1ba6b34
Compare
This is a great help in debugging, and I don't think there's much downside to doing that? Capturing a backtrace is somewhat costly, especially on windows, but given that we run with panic=abort, that's bound to be a pretty cold path anyways! To disable backtraces, set `RUST_BACKTRACE=0` env variable.
matklad
force-pushed
the
m/force-backtrace
branch
from
1ba6b34
to
9da8d26
Compare
mm-near
approved these changes
Sep 7, 2022
nikurt
pushed a commit
that referenced
this pull request
Sep 7, 2022
This is a great help in debugging, and I don't think there's much downside to doing that? Capturing a backtrace is somewhat costly, especially on windows, but given that we run with panic=abort, that's bound to be a pretty cold path anyways! To disable backtraces, set `RUST_BACKTRACE=0` env variable. Test Plan --------- Manually check that both default&override work
nikurt
pushed a commit
that referenced
this pull request
Nov 9, 2022
This is a great help in debugging, and I don't think there's much downside to doing that? Capturing a backtrace is somewhat costly, especially on windows, but given that we run with panic=abort, that's bound to be a pretty cold path anyways! To disable backtraces, set `RUST_BACKTRACE=0` env variable. Test Plan --------- Manually check that both default&override work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a great help in debugging, and I don't think there's much
downside to doing that? Capturing a backtrace is somewhat costly,
especially on windows, but given that we run with panic=abort, that's
bound to be a pretty cold path anyways!
To disable backtraces, set
RUST_BACKTRACE=0env variable.Test Plan
Manually check that both default&override work