Prefer to_string to format!("{}")
#7581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per benchmarks in near#7568, using format! as opposed to calling to_string directly has ~100ns overhead. There’s no reason not to get rid of that overhead especially since using to_string is actually shorter to type. Note that it may be beneficial to further optimise integer formatting by using fixed-size buffer and custom conversion which doesn’t use std. This optimisation is outside the scope of this commit.
|
Let's wait for the end of the investigation. |
matklad
approved these changes
Sep 7, 2022
There was a problem hiding this comment.
I wouldn't worry about performance here: if format! vs to_string matters you probably should not be using strnigs at all.
But this is a good change on the grounds of code style alone, format!("{}", foo) is highly unidiomatic, foo.to_string() is the way to spell that.
This changes more than just instances with metrics so even if metrics are changed we’ll still want to change other places to use to_string. |
nikurt
approved these changes
Sep 7, 2022
nikurt
pushed a commit
that referenced
this pull request
Nov 9, 2022
As per benchmarks in #7568, using format! as opposed to calling to_string directly has ~100ns overhead. There’s no reason not to get rid of that overhead especially since using to_string is actually shorter to type. Note that it may be beneficial to further optimise integer formatting by using fixed-size buffer and custom conversion which doesn’t use std. This optimisation is outside the scope of this commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per benchmarks in #7568, using
format! as opposed to calling to_string directly has ~100ns
overhead. There’s no reason not to get rid of that overhead especially
since using to_string is actually shorter to type.
Note that it may be beneficial to further optimise integer formatting
by using fixed-size buffer and custom conversion which doesn’t use
std. This optimisation is outside the scope of this commit.