refactor: streamline contract caching code #7851
Merged
Commits on Oct 18, 2022
-
refactor: streamline contract caching code
This does two rather big code motions at the same time (sorry!): * precompilation code is moved from "let's match on VMKind" style to "let's call Runtime's virtual method". To do so, we re-purpose existing `precompile` functions in the trait. Remember, those fns are essentially dead code from "pipelined" compilation * code to deal with our two-layered caching is moved from `cache.rs` into impls of VM
-
emit dedicated error when loading a contract fails
This happens either due to resource exhaustion, or when zero-copy deserialized data is invalid
-
-
-
-
fix: don't load the contract during compilation
This fixes `test_two_deployments`. The fix is to ensure that `precompile` *only* compiles and caches the contract, without loading it. This reshuffles error yet again, as `LoadingError` moves from `CacheError` to `VMRunnerError`, where it actually belongs.
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.