Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: honor NO_COLOR in tests #8063

Merged
merged 3 commits into from
Nov 18, 2022
Merged

feat: honor NO_COLOR in tests #8063

merged 3 commits into from
Nov 18, 2022

Conversation

matklad
Copy link
Contributor

@matklad matklad commented Nov 16, 2022

No description provided.

@matklad matklad requested a review from a team as a code owner November 16, 2022 11:13
robin-near
robin-near approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@robin-near robin-near left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@matklad
Copy link
Contributor Author

matklad commented Nov 17, 2022

(and see tokio-rs/tracing#2388 for an upstream issue )

@near-bulldozer near-bulldozer bot merged commit 667b7fe into near:master Nov 18, 2022
@matklad matklad deleted the m/color branch November 18, 2022 12:23
nikurt pushed a commit that referenced this pull request Nov 22, 2022
@matklad @nikurt
feat: honor NO_COLOR in tests (#8063)
e757a08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nagisa nagisa nagisa approved these changes

@robin-near robin-near robin-near approved these changes

@mzhangmzz mzhangmzz Awaiting requested review from mzhangmzz mzhangmzz is a code owner automatically assigned from near/nearcore-codeowners

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matklad @nagisa @robin-near