primitives: get rid of Cursor #8194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per the TODO, take `&[u8; 36]` in ValueRef::decode and stop using Cursor. This makes the method considerably simpler without making the call site more complex. While dealing with ValueRef, stop using Cursor in account_id_to_shard_id as well. Issue: near#7327
nikurt
approved these changes
Dec 9, 2022
|
tests::network::ban_peers::connect_to_unbanned_peer appears flaky. |
nikurt
pushed a commit
to nikurt/nearcore
that referenced
this pull request
Dec 19, 2022
As per the TODO, take `&[u8; 36]` in ValueRef::decode and stop using Cursor. This makes the method considerably simpler without making the call site more complex. While dealing with ValueRef, stop using Cursor in account_id_to_shard_id as well. Issue: near#7327
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the TODO, take
&[u8; 36]in ValueRef::decode and stop usingCursor. This makes the method considerably simpler without making the
call site more complex. While dealing with ValueRef, stop using
Cursor in account_id_to_shard_id as well.
Issue: #7327