feature: Structured parameters config #8384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakmeier
reviewed
Jan 18, 2023
jakmeier
approved these changes
Jan 18, 2023
aborg-dev
force-pushed
the
structured_config
branch
from
a809190 to
7354721
Compare
nikurt
pushed a commit
to nikurt/nearcore
that referenced
this pull request
Jan 30, 2023
This is a part of near#8264. This PR introduces structured values for Rationals in the parameter config in the form ```yaml burnt_gas_reward: { numerator: 3, denominator: 10, } ``` To support this in the code, we now interpret parameter values as one of ```rust enum ParameterValue { Null, U64(u64), Rational { numerator: isize, denominator: isize }, String(String), } ``` In the future the plan is to extend this to support Fee structure and Weighted parameters. One open Rust-related question here: - [ ] What is a good way to deduplicate code between `get_number`, `get_string`, `get_rational` methods? Things to finish: - [x] Tests for the Rational type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a part of #8264.
This PR introduces structured values for Rationals in the parameter config in the form
To support this in the code, we now interpret parameter values as one of
In the future the plan is to extend this to support Fee structure and Weighted parameters.
One open Rust-related question here:
get_number,get_string,get_rationalmethods?Things to finish: