Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump paperclip from 0.7.0 to 0.8.0 #8392

Merged
merged 3 commits into from
Jan 19, 2023

Conversation

aborg-dev
Copy link
Contributor

@aborg-dev aborg-dev commented Jan 19, 2023

To unblock serde_yaml update for #8320

I wasn't sure what the policy was, so updated to the latest version of paperclip crate. Please, let me know if I should chose some other version instead.

There is another very similar PR happening in parallel #8390 that is also necessary for the serde_yaml update and is blocking this PR, so feel free to take a look at that one as well ^^

@aborg-dev aborg-dev requested a review from a team as a code owner January 19, 2023 09:47
@aborg-dev aborg-dev requested a review from nikurt January 19, 2023 09:47
nikurt
nikurt previously approved these changes Jan 19, 2023
@nikurt
Copy link
Contributor

nikurt commented Jan 19, 2023

LGTM in general, but please see the tests failing. If needed, add a package to deny.toml.

+ cargo-deny --all-features check bans
error[B004]: found 2 duplicate entries for crate 'serde_yaml'
    ┌─ /var/lib/buildkite-agent/builds/buildkite-i-0935a6d5bcf23961e-1/nearprotocol/nearcore/Cargo.lock:452:1
    │
452 │ ╭ serde_yaml 0.8.26 registry+https://github.com/rust-lang/crates.io-index
453 │ │ serde_yaml 0.9.16 registry+https://github.com/rust-lang/crates.io-index
    │ ╰───────────────────────────────────────────────────────────────────────^ lock entries

Copy link
Contributor

@nikurt nikurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the tests

@aborg-dev aborg-dev force-pushed the bump_paperclip branch 2 times, most recently from 4208c12 to 0da2f06 Compare January 19, 2023 13:25
@aborg-dev
Copy link
Contributor Author

I actually needed to include serde_yaml migration to 0.9 in this PR as it was necessary to fix check for multiple versions of the same library. As a part of this, I've also removed the workarounds for the old serde_yaml version.

So now this PR fixes #8320.

Copy link
Contributor

@nikurt nikurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@near-bulldozer near-bulldozer bot merged commit c86529a into near:master Jan 19, 2023
nikurt pushed a commit to nikurt/nearcore that referenced this pull request Jan 30, 2023
To unblock serde_yaml update for near#8320

I wasn't sure what the policy was, so updated to the latest version of `paperclip` crate. Please, let me know if I should chose some other version instead.

There is another very similar PR happening in parallel near#8390 that is also necessary for the `serde_yaml` update and is blocking this PR, so feel free to take a look at that one as well ^^
@aborg-dev aborg-dev added the C-housekeeping Category: Refactoring, cleanups, code quality label Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-housekeeping Category: Refactoring, cleanups, code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants