-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flat_storage_creation_enabled config flag #8923
Merged
near-bulldozer
merged 3 commits into
near:master
from
pugachAG:flat-storage-creation-enabled-flag
Apr 18, 2023
Merged
Add flat_storage_creation_enabled config flag #8923
near-bulldozer
merged 3 commits into
near:master
from
pugachAG:flat-storage-creation-enabled-flag
Apr 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pugachAG
requested review from
jakmeier and
Longarithm
and removed request for
jakmeier
April 18, 2023 11:32
Longarithm
approved these changes
Apr 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I see, now we don't write any data to DB when FlatStorageCreator::new is called, so this looks correct.
nikurt
approved these changes
Apr 18, 2023
pugachAG
changed the title
Add flat_storage_creation_enabled flag
Add flat_storage_creation_enabled config flag
Apr 18, 2023
nikurt
pushed a commit
that referenced
this pull request
Apr 18, 2023
Part of #8827. Adds `flat_storage_creation_enabled` config flag to enable/disable flat storage creation. The default value is `true`. This is needed for SREs to be able to manually enable/disable flat storage creation when taking state backup.
nikurt
pushed a commit
that referenced
this pull request
Apr 25, 2023
Part of #8827. Adds `flat_storage_creation_enabled` config flag to enable/disable flat storage creation. The default value is `true`. This is needed for SREs to be able to manually enable/disable flat storage creation when taking state backup.
nikurt
pushed a commit
that referenced
this pull request
Apr 28, 2023
Part of #8827. Adds `flat_storage_creation_enabled` config flag to enable/disable flat storage creation. The default value is `true`. This is needed for SREs to be able to manually enable/disable flat storage creation when taking state backup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #8827.
Adds
flat_storage_creation_enabled
config flag to enable/disable flat storage creation. The default value istrue
.This is needed for SREs to be able to manually enable/disable flat storage creation when taking state backup.