Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flat_storage_creation_enabled config flag #8923

Merged

Conversation

pugachAG
Copy link
Contributor

@pugachAG pugachAG commented Apr 18, 2023

Part of #8827.

Adds flat_storage_creation_enabled config flag to enable/disable flat storage creation. The default value is true.

This is needed for SREs to be able to manually enable/disable flat storage creation when taking state backup.

@pugachAG pugachAG linked an issue Apr 18, 2023 that may be closed by this pull request
@pugachAG pugachAG marked this pull request as ready for review April 18, 2023 11:32
@pugachAG pugachAG requested a review from a team as a code owner April 18, 2023 11:32
@pugachAG pugachAG requested review from jakmeier and Longarithm and removed request for jakmeier April 18, 2023 11:32
Copy link
Member

@Longarithm Longarithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I see, now we don't write any data to DB when FlatStorageCreator::new is called, so this looks correct.

core/store/src/config.rs Outdated Show resolved Hide resolved
@pugachAG pugachAG changed the title Add flat_storage_creation_enabled flag Add flat_storage_creation_enabled config flag Apr 18, 2023
@pugachAG pugachAG added A-storage Area: storage and databases S-automerge labels Apr 18, 2023
@near-bulldozer near-bulldozer bot merged commit 62921b9 into near:master Apr 18, 2023
nikurt pushed a commit that referenced this pull request Apr 18, 2023
Part of #8827.

Adds `flat_storage_creation_enabled` config flag to enable/disable flat storage creation. The default value is `true`.

This is needed for SREs to be able to manually enable/disable flat storage creation when taking state backup.
nikurt pushed a commit that referenced this pull request Apr 25, 2023
Part of #8827.

Adds `flat_storage_creation_enabled` config flag to enable/disable flat storage creation. The default value is `true`.

This is needed for SREs to be able to manually enable/disable flat storage creation when taking state backup.
nikurt pushed a commit that referenced this pull request Apr 28, 2023
Part of #8827.

Adds `flat_storage_creation_enabled` config flag to enable/disable flat storage creation. The default value is `true`.

This is needed for SREs to be able to manually enable/disable flat storage creation when taking state backup.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-storage Area: storage and databases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add config option to enable/disable background FS creation
3 participants