fix(state-sync): Enable State Sync from GCS by default #9398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RoutingTableView in the debug UI includes a table over the direct peers of the node: <img width="516" alt="image" src="https://github.com/near/nearcore/assets/3241341/c8c1f0b8-1e0a-458e-a2ad-f09f20fcb57c"> Each active connection of the node has one row in the table. The last column is populated using the most recent distance vector shared by the direct peer. In some cases there may be a direct connection for which we have not received a distance vector yet. This PR allows the debug UI to gracefully handle such cases and display "null" instead of producing an error.
ppca
approved these changes
Aug 8, 2023
| } | ||
| if matches!(state_sync_config, SyncConfig::Peers) { | ||
| // TODO #8719 | ||
| tracing::warn!( |
There was a problem hiding this comment.
instead of removing this message, should we replace with a message saying "node is syncing its state! If this failed, please do the following xxx"?
marcelo-gonzalez
approved these changes
Aug 9, 2023
ppca
pushed a commit
that referenced
this pull request
Aug 9, 2023
* fix(state-sync): Enable State Sync from GCS by default * fix(state-sync): Enable State Sync from GCS by default * RoutingTableView: gracefully handle missing distance vectors (#9394) The RoutingTableView in the debug UI includes a table over the direct peers of the node: <img width="516" alt="image" src="https://github.com/near/nearcore/assets/3241341/c8c1f0b8-1e0a-458e-a2ad-f09f20fcb57c"> Each active connection of the node has one row in the table. The last column is populated using the most recent distance vector shared by the direct peer. In some cases there may be a direct connection for which we have not received a distance vector yet. This PR allows the debug UI to gracefully handle such cases and display "null" instead of producing an error. * fix(state-sync): Enable State Sync from GCS by default * fix(state-sync): Enable State Sync from GCS by default * fix(state-sync): Enable State Sync from GCS by default --------- Co-authored-by: Saketh Are <saketh.are@gmail.com>
nikurt
added a commit
that referenced
this pull request
Aug 24, 2023
* fix(state-sync): Enable State Sync from GCS by default * fix(state-sync): Enable State Sync from GCS by default * RoutingTableView: gracefully handle missing distance vectors (#9394) The RoutingTableView in the debug UI includes a table over the direct peers of the node: <img width="516" alt="image" src="https://github.com/near/nearcore/assets/3241341/c8c1f0b8-1e0a-458e-a2ad-f09f20fcb57c"> Each active connection of the node has one row in the table. The last column is populated using the most recent distance vector shared by the direct peer. In some cases there may be a direct connection for which we have not received a distance vector yet. This PR allows the debug UI to gracefully handle such cases and display "null" instead of producing an error. * fix(state-sync): Enable State Sync from GCS by default * fix(state-sync): Enable State Sync from GCS by default * fix(state-sync): Enable State Sync from GCS by default --------- Co-authored-by: Saketh Are <saketh.are@gmail.com>
nikurt
added a commit
to nikurt/nearcore
that referenced
this pull request
Aug 24, 2023
* fix(state-sync): Enable State Sync from GCS by default * fix(state-sync): Enable State Sync from GCS by default * RoutingTableView: gracefully handle missing distance vectors (near#9394) The RoutingTableView in the debug UI includes a table over the direct peers of the node: <img width="516" alt="image" src="https://github.com/near/nearcore/assets/3241341/c8c1f0b8-1e0a-458e-a2ad-f09f20fcb57c"> Each active connection of the node has one row in the table. The last column is populated using the most recent distance vector shared by the direct peer. In some cases there may be a direct connection for which we have not received a distance vector yet. This PR allows the debug UI to gracefully handle such cases and display "null" instead of producing an error. * fix(state-sync): Enable State Sync from GCS by default * fix(state-sync): Enable State Sync from GCS by default * fix(state-sync): Enable State Sync from GCS by default --------- Co-authored-by: Saketh Are <saketh.are@gmail.com>
nikurt
added a commit
that referenced
this pull request
Aug 28, 2023
* fix(state-sync): Enable State Sync from GCS by default * fix(state-sync): Enable State Sync from GCS by default * RoutingTableView: gracefully handle missing distance vectors (#9394) The RoutingTableView in the debug UI includes a table over the direct peers of the node: <img width="516" alt="image" src="https://github.com/near/nearcore/assets/3241341/c8c1f0b8-1e0a-458e-a2ad-f09f20fcb57c"> Each active connection of the node has one row in the table. The last column is populated using the most recent distance vector shared by the direct peer. In some cases there may be a direct connection for which we have not received a distance vector yet. This PR allows the debug UI to gracefully handle such cases and display "null" instead of producing an error. * fix(state-sync): Enable State Sync from GCS by default * fix(state-sync): Enable State Sync from GCS by default * fix(state-sync): Enable State Sync from GCS by default --------- Co-authored-by: Saketh Are <saketh.are@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.