feat(epoch-sync): adding EpochSyncInfo column and its continuous population #9440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikurt
approved these changes
Aug 16, 2023
Co-authored-by: nikurt <86772482+nikurt@users.noreply.github.com>
Yes. |
nikurt
pushed a commit
to nikurt/nearcore
that referenced
this pull request
Aug 24, 2023
…lation (near#9440) Adding EpochSyncInfo column and its population on epoch end in block postprocessing.
nikurt
pushed a commit
that referenced
this pull request
Aug 28, 2023
…lation (#9440) Adding EpochSyncInfo column and its population on epoch end in block postprocessing.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 2, 2023
#10029 The fix is 10 lines in `chain/chain/src/chain.rs`. Everything else is for testing. I don't like this approach, I am fixing a symptom, not the problem. But it is good enough for now (and possibly forever). But, just for context, **the problem** is as follows. We should write `EpochSyncInfo` every time we write `EpochInfo` of a full epoch. It is fine not to write `EpochSyncInfo` for genesis epoch of one block for two reasons: - Everyone has full genesis epoch on startup - Next epoch has the same `epoch_id` and therefore it is incorrect to have that key in DB before the end of first proper epoch `EpochInfo` is written in function `record_block_info` that is called from `add_validator_proposals`. Both function belong to `EpochManager`, and we cannot add `EpochSyncInfo` generation to `EpochManager`, as it requires headers (including the last header of an epoch, that is probably not written into DB during the execution of anything in `EpochManager`). From an architecture point of view `EpochSyncInfo` generation is a `Chain` function. So, I couldn't enforce that `EpochSyncInfo` is tied to `EpochInfo` generation. But I traced every usage of `add_validator_proposals`, and we have only two usages that are - in `neard` - not in tests - not related to genesis epoch First usage was covered by the commit that introduced `EpochSyncInfo` #9440. Second usage is covered with this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step towards new epoch sync. Everything should be under new_epoch_sync feature.
Design doc: https://docs.google.com/document/d/14Itc9Hs7ewTRmcGANid9UCaYcJzaLzzM7FsvYYIFKDY/edit
Adding EpochSyncInfo column and its population on epoch end in block postprocessing.