Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: undo gas_limit renaming #9558

Merged
merged 2 commits into from
Sep 22, 2023
Merged

refactor: undo gas_limit renaming #9558

merged 2 commits into from
Sep 22, 2023

Conversation

pugachAG
Copy link
Contributor

Chunk header gas_limit was renamed to prev_gas_limit in #9500. After discussion with @jakmeier I've realised while it is determined in the previous chunk, it actually corresponds to gas limit for the current chunk.

@pugachAG pugachAG added the A-chain Area: Chain, client & related label Sep 21, 2023
@pugachAG pugachAG requested a review from a team as a code owner September 21, 2023 16:22
@pugachAG pugachAG added this pull request to the merge queue Sep 22, 2023
Merged via the queue into near:master with commit c626701 Sep 22, 2023
@pugachAG pugachAG deleted the rename-back-gas-limit branch September 22, 2023 13:57
nikurt pushed a commit that referenced this pull request Sep 26, 2023
@pugachAG @nikurt
refactor: undo gas_limit renaming (#9558)
bc83bb2 
Chunk header `gas_limit` was renamed to `prev_gas_limit` in
#9500. After discussion with
@jakmeier I've realised while it is determined in the previous chunk, it
actually corresponds to gas limit for the current chunk.
nikurt pushed a commit that referenced this pull request Sep 26, 2023
@pugachAG @nikurt
refactor: undo gas_limit renaming (#9558)
aef043b 
Chunk header `gas_limit` was renamed to `prev_gas_limit` in
#9500. After discussion with
@jakmeier I've realised while it is determined in the previous chunk, it
actually corresponds to gas limit for the current chunk.
nikurt pushed a commit that referenced this pull request Oct 2, 2023
@pugachAG @nikurt
refactor: undo gas_limit renaming (#9558)
d9dc5cc 
Chunk header `gas_limit` was renamed to `prev_gas_limit` in
#9500. After discussion with
@jakmeier I've realised while it is determined in the previous chunk, it
actually corresponds to gas limit for the current chunk.
nikurt pushed a commit that referenced this pull request Oct 11, 2023
@pugachAG @nikurt
refactor: undo gas_limit renaming (#9558)
ce230e1 
Chunk header `gas_limit` was renamed to `prev_gas_limit` in
#9500. After discussion with
@jakmeier I've realised while it is determined in the previous chunk, it
actually corresponds to gas limit for the current chunk.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakmeier jakmeier jakmeier approved these changes

@wacban wacban Awaiting requested review from wacban

@Longarithm Longarithm Awaiting requested review from Longarithm

@robin-near robin-near Awaiting requested review from robin-near

Assignees
No one assigned
Labels
A-chain Area: Chain, client & related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pugachAG @jakmeier