This repository has been archived by the owner on Oct 20, 2020. It is now read-only.
test(eth-proofs): Fix and test Eth proofs on NEAR #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic for proof verification currently has some drawbacks.
The logic to verifacate proofs from the Ethereum blockchain
in the NEAR side of the bridge was improved with:
- Handle all types of keys, previously it was only possible to
prove receipts and transactions, now also state can be proved.
- It doesn't use unrecoverable erros anymore to mark an invalid
proof, instead it always return boolean value.
- Some nits in the code.
Test plan
=========
- Verify all recipts and transaction from the Ethereum blockchain up to
some point.
- Verify state/storage proofs work.
- Proof code has 100% coverage.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic for proof verification currently has some drawbacks.
The logic to verifacate proofs from the Ethereum blockchain
in the NEAR side of the bridge was improved with:
Handle all types of keys, previously it was only possible to
prove receipts and transactions, now also state can be proved.
It doesn't use unrecoverable erros anymore to mark an invalid
proof, instead it always return boolean value.
Some nits in the code.
The main resources used to understand and implement the verification was:
Test plan
verify_trie_proofcode has 100% coverage.