Fix npm run on Windows

[aborg-dev]

This PR customized the path to NPM that we use on the Windows platform.

It is inspired by https://github.com/oscartbeaumont/rspc/blob/03240ddca56dc5a473a8652296f648c2e1d3987b/crates/create-rspc-app/src/post_gen.rs#L48

[mooori]

This PR customized the path to NPM that we use on the Windows platform.

Isn't it the same path, but another way of invoking npm? That's my interpretation based on this post, though I'm not familiar with running commands on Windows.

[aborg-dev]

I'm also confused by this - my understanding so far, is that direct npm invocation does not work because of the different handling of PATH variable on Windows.
Adding cmd here is supposed to add another layer of indirection that allows the GitHub action runner to inject the correct PATH variable (which is also defined in GITHUB_PATH workflow variable).

I struggle to find any decent documentation about this PATH behaviour, but FWIW, the example from Rust docs uses cmd on Windows: https://doc.rust-lang.org/nightly/std/process/struct.Command.html

[nagisa]

I don't necessarily disagree with the fix, but beware that invoking through cmd like this can change the interpretation of the arguments. This can lead to some extremely frustrating to debug problems later down the line.

If it does work currently, then its fine, of course, especially since nobody out of us seriously uses windows for development and thus GHA is the only thing that needs to work. Using the which crate as suggested in the referenced PR sounds like it may be a straightforward improvement in the reliability aspect (though with its own tradeoffs -- adding a dependency potentially means more difficult merges down the line.)

Adding cmd here is supposed to add another layer of indirection that allows the GitHub action runner to inject the correct PATH variable (which is also defined in GITHUB_PATH workflow variable).

FWIW the rust test runner is already invoked by cmd so the %PATH% should be already correct.

[mooori]

Thanks for the references! Given that standard lib docs and other popular projects do the same, I suppose it is the right thing to do.