feat: private registry with multiple secrets #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate registry credentials in knative service manifest
ghost
mentioned this pull request
zaremba-tomasz
approved these changes
Oct 13, 2023
| &cli.StringSliceFlag{ | ||
| Name: imagePullSecretsFlag, | ||
| Usage: "Define one or more (repeating the flag or in csv format for the environment variable) image pull secrets", | ||
| EnvVars: []string{"INITIUM_IMAGE_PULL_SECRETS"}, |
There was a problem hiding this comment.
This one is splitting by , by default?
There was a problem hiding this comment.
Yes, that's implemented by the library
LucaLanziani
deleted the
feature/private-registry-with-multiple-secrets
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.