feat: add registry-secret param / envvar #94
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate registry credentials in knative service manifest
proxhavasi
force-pushed
the
feature/private-registry
branch
from
6b04b0e
to
1404f18
Compare
LucaLanziani
requested changes
Aug 30, 2023
|
The tests clearly show the problem @proxhavasi |
ghost
requested review from
LucaLanziani and
zaremba-tomasz
and removed request for
LucaLanziani
zaremba-tomasz
suggested changes
Oct 4, 2023
zaremba-tomasz
approved these changes
Oct 5, 2023
LucaLanziani
reviewed
Oct 6, 2023
Co-authored-by: Luca Lanziani <luca@lanziani.com>
ghost
approved these changes
Oct 9, 2023
|
closing this in favor of #130 |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow setting custom private registry credentials in knative service manifest - closes #84