Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plans to make Normalize eyeglass compatible? #638

Closed
ashleynolan opened this issue Oct 15, 2016 · 11 comments
Closed

Any plans to make Normalize eyeglass compatible? #638

ashleynolan opened this issue Oct 15, 2016 · 11 comments
Assignees
Labels

Comments

@ashleynolan
Copy link

ashleynolan commented Oct 15, 2016

I was just wondering if there was any plan to make the NPM module of Normalize compatible with Eyeglass?

I’ve seen there’s a sass version of normalize which is eyeglass compatible, but all I really want to pull into my projects is the straight up Normalize CSS, so was wondering if this was planned, or whether it would be worth me forking the repo and making a module that does this. Alternatively, I’d be happy to submit a PR to add this, if it would be something that you’d want to look to include.

Thanks for all the great work on the project.

@ashleynolan ashleynolan changed the title Any plans to make the normalize eyeglass compatible? Any plans to make Normalize eyeglass compatible? Oct 15, 2016
@battaglr
Copy link
Contributor

@ashleynolan, it's really hard to keep track of all these tools coming up. What changes would be necessary to support this?

@ashleynolan
Copy link
Author

I’ll try and get something working in a fork so that I can see exactly what needs to be done and link to it as an example. Will post back here once I’ve done that (will be in the next couple of days)

@battaglr
Copy link
Contributor

battaglr commented Oct 25, 2016

@ashleynolan, no need to code anything at this point. I just wanted to know if we need to include a new file, an entry on the package.json or something else.

@ashleynolan
Copy link
Author

ashleynolan commented Oct 25, 2016

You can do it in a couple of ways, but the easiest is by including a few lines in the package.json.

You need to add "eyeglass-module" as a keyword and then a set of eyeglass options (like this).

Then after adding these, it should be possible to install Normalise via NPM and include it in a Sass build by just referencing @import normalise (or whatever import keyword you give it in the package.json).

@battaglr
Copy link
Contributor

@ashleynolan, great that's great info, thank you! @jonathantneal, what do you think about this?

@kevva
Copy link

kevva commented Oct 25, 2016

I wonder why authors to these tools are trying to make module authors adapt to them rather than the other way. One would expect that eyeglass somehow could make use of the main field instead when no other options exists or whatever.

@battaglr
Copy link
Contributor

@kevva, I wonder the same thing... 😞

@jonathantneal
Copy link
Contributor

@ashleynolan, are we able to add JUST the "eyeglass-module" keyword to make it compatible? If it requires more, do let me know the additional code you’ll need.

@jonathantneal
Copy link
Contributor

Hey all, I’ll be closing this issue if we’re unable to get clearer instructions or an answer to my question by the 1st of January. Just trying to keep things moving along.

@ashleynolan
Copy link
Author

@jonathantneal Sorry for not replying – should have kept on top of this.

From what I’ve done in the past, it involves adding the keyword and then having to add a couple of lines such as this. These point to the directory of the module, the name you want people to import the module as and the version of eyeglass supported.

@jonathantneal
Copy link
Contributor

A PR for this could be made. I have not seen movement on this, though, so I am closing it.

Snugug pushed a commit to Snugug/normalize.css that referenced this issue Sep 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants