Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React 18 support #2196

Closed
gut4 opened this issue Jan 12, 2022 · 3 comments
Closed

React 18 support #2196

gut4 opened this issue Jan 12, 2022 · 3 comments
Labels
has: pr Subject of a pull request
Milestone
0.18: StyleSheet

Comments

@gut4
Copy link

gut4 commented Jan 12, 2022

Any plans/roadmap to support react 18 concurrent features?

Looks like style system need changes
reactwg/react-18#110
@billouboq
Copy link

I think they are working on stylex at the moment with other people from facebook so we don't have to worry about react 18 support.

But yeah I'm really excited to know when those changes are going to be included in react-native-web 😄

@necolas necolas mentioned this issue Jan 31, 2022
Closed
7 tasks
@necolas
Copy link
Owner

necolas commented Jan 31, 2022

See #2208 for a build that should support React 18 constraints

@necolas necolas added this to the 0.18: StyleSheet milestone Mar 1, 2022
necolas added a commit that referenced this issue Mar 2, 2022
@necolas
[change] StyleSheet rewrite
e342a02 
* Improves React Native compatibility by making StyleSheet.create the identify function.
* Improves React 18 support by inserting styles on eval.
* Supports use with multiple windows (i.e., iframes) and shadow roots.
* Supports nested LTR/RTL layouts.
* Supports 3rd party compilers and extraction to static CSS.
* Fixes static and dynamic short/longform deduplication.
* Reduces browser support: Safari 10.1+, Chromium Edge, no IE, no legacy Android browsers.
* Removes automatic vendor-prefixing of inline styles (for better perf).
* Removes focus-visible polyfill as modern browsers no longer show focus rings for mouse interactions.

Close #2208
Fix #2138
Fix #2196
Fix #2007
Fix #1517
@necolas necolas added the has: pr Subject of a pull request label Mar 2, 2022
@necolas necolas mentioned this issue Mar 23, 2022
Merged
rnike pushed a commit to VeryBuy/react-native-web that referenced this issue Sep 13, 2022
@necolas
[change] StyleSheet rewrite
3a6691e 
* Improves React Native compatibility by making StyleSheet.create the identify function.
* Improves React 18 support by inserting styles on eval.
* Supports use with multiple windows (i.e., iframes) and shadow roots.
* Supports nested LTR/RTL layouts.
* Supports 3rd party compilers and extraction to static CSS.
* Fixes static and dynamic short/longform deduplication.
* Reduces browser support: Safari 10.1+, Chromium Edge, no IE, no legacy Android browsers.
* Removes automatic vendor-prefixing of inline styles (for better perf).
* Removes focus-visible polyfill as modern browsers no longer show focus rings for mouse interactions.

Close necolas#2208
Fix necolas#2138
Fix necolas#2196
Fix necolas#2007
Fix necolas#1517
@ulantiger
Copy link

Hi there,

Got following error during installation:
Could not resolve dependency:
npm ERR! peer react@"^18.2.0" from react-dom@18.2.0
npm ERR! node_modules/react-dom
npm ERR! react-dom@"^18.1.0" from the root project
npm ERR! peer react-dom@"^17.0.2 || ^18.0.0" from react-native-web@0.18.10
npm ERR! node_modules/react-native-web
npm ERR! react-native-web@"*" from the root project

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
has: pr Subject of a pull request
Projects
None yet
Milestone
0.18: StyleSheet
Development

Successfully merging a pull request may close this issue.

StyleSheet with styleq runtime necolas/react-native-web
4 participants
@gut4 @necolas @billouboq @ulantiger