-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix enterKeyHint dom prop #1707
Conversation
Please can you include a test case? This error gets printed in the unit tests with this patch:
|
Oh I see, looks like it was only added in react@17, facebook/react#18634. Not sure what would be the proper way to support both versions. |
It's just a React warning and there's no functional consequence though, right? |
Not sure, I'll check to see if the prop still shows up in the DOM when using the |
Any plans to merge this in soon? |
No, because then the warning will appear in React 16. This change will probably go into 0.15 which will make React 17 the peer dependency. |
On this commit facebook/react@feb134c enterKeyHint added to react-dom standard names. |
Getting this error with:
|
I see your fix from PR is really relevant. |
This PR is good. When we could merge this? |
If you do |
Any update about this issue? |
Can we get this merged please? |
It would be great to get this merged :) |
|
React 17 added support for this prop so it now requires a camelCase form. Close necolas#1707
React warns about this prop since it should be
enterKeyHint
instead of the DOM capitalizationenterkeyhint
.Tested that the prop is properly set in the DOM after this change.