update with upstream #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The word `strings` is repeated unnecessarily
Add second `:`
In the example, somebody who is trying to understand this code has to follow a lot of moving pieces: prefix, name, make_greeter, and then also learn the new move concept at the same time. It'd be better if the content were to actually match the name of the variables. "Hi" is a good prefix, but "there" is not a name, so let's go with an actual name.
This is a contribution of a break-continue section for Comprehensive Rust.   --------- Co-authored-by: Dustin J. Mitchell <dustin@v.igoro.us>
Tested with rust 2015, 2018, 2021 and 2024, on amd64 musl, amd64 glibc and aarch64 musl, all of them represent Strings with (ptr, capacity, len). This is an internal implementation detail, that shouldn't be exposed anyway, so it's no big deal, but in the speaker notes, we provide a debugging tool for demonstration purposes, so at least that should have a correct output.
The po file has been refreshed. Translation range: L1173-L2241. #324 --------- Co-authored-by: Yihao Wang <42559837+AgainstEntropy@users.noreply.github.com>
I added a tranlation correction on the line 1287, I change "tres" instead "cuatro", because "cuatro" is the meaningful of four in Spanish. --------- Co-authored-by: Henri F <henrif75@users.noreply.github.com>
This is a clean refresh, requires only a syntactical review. You can skim this PR with the [GitHub CLI](https://cli.github.com/): ``` gh pr diff 1742 | bat -l patch ```
This is a clean refresh, requires only a syntaxtical review. You can skim this PR with the [GitHub CLI](https://cli.github.com/): ``` gh pr diff 1751 | bat -l patch ```
I added a tranlation correction on the line 1287, I change "tres" instead "cuatro", because "cuatro" is the meaningful of four in Spanish. --------- Co-authored-by: Henri F <henrif75@users.noreply.github.com>
Bumps the patch group with 1 update: [clap](https://github.com/clap-rs/clap). Updates `clap` from 4.5.0 to 4.5.1 Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Day 3: morning Signed-off-by: Andriy Redko <drreta@gmail.com>
`id` of `h1` title in the translated version will be changed to the translated text. Fixed `id` configured here will not take effect in the translated version. Correct style: https://google.github.io/comprehensive-rust/glossary.html Wrong style (zh-CN): https://google.github.io/comprehensive-rust/zh-CN/glossary.html
Add heading attributes[1] to avoid ID changes in translation. [1]: https://rust-lang.github.io/mdBook/format/markdown.html#heading-attributes Related: #1825 --------- Co-authored-by: Martin Geisler <martin@geisler.net>
Updates `mdbook-pandoc` to [0.5.0](https://github.com/max-heller/mdbook-pandoc/releases/tag/v0.5.0) to use some new features: - Table wrapping (closes #1709) The wrapping logic mirror's [Pandoc's](https://pandoc.org/MANUAL.html#extension-pipe_tables) (i.e., compare the relative widths of the `---` columns to determine column widths) so tables in the source may need tweaking to get the proportions right - Replace broken links in PDF with corresponding links to https://google.github.io/comprehensive-rust/
In the old version, using "break 'outer;" and using "break;" (without the label) produce the same output. This version fixes that to make the example more illustrative. --------- Co-authored-by: Martin Geisler <martin@geisler.net>
Co-authored-by: Martin Geisler <mgeisler@google.com>
The first change is to reformulate the English in a way, that emphasizes, that this is not a decision of the compiler, but the impossibility of computing an infinite value (e.g. changed the language from "not compute" to "would not be able to compute"). The second change is to fix the error message, of course the error message from the compiler is "recursive withOUT indirection", as "recursive with indirection" is actually what we want.
This will add a little more context. See the current result in #1813.
I was reading the docs and I stumbled upon this. I'm unsure about when exercises should be solved directly on the site and when they should be copied and pasted into a playground. But since the previous chapter's exercise is solvable in the site [(fibonacci sequence)](https://github.com/google/comprehensive-rust/blob/0cb7f496b542d76468fa950718f57f4037abc8fa/src/types-and-values/exercise.md?plain=1#L15), I figured this one might be missing the attribute. Anyway amazing work on the docs!
iterating over the vector instead of hardcoding each item --------- Co-authored-by: Martin Geisler <mgeisler@google.com>
This breaks the "Traits" slide into three smaller sub-slides. It also addresses part of #1511 by explicitly addressing associated types. --------- Co-authored-by: Martin Geisler <martin@geisler.net>
Having the tests only in the result brings less value, so the participants can do it following TDD practices
Allow us to edit so we can complete the exercise :)
The current location for the hello world example is awkward since the two surrounding pages are both talking about Rust from a high level without talking about syntax at all. I think starting the second section (types and values) with the hello world example would help the first section flow more smoothly.
Re #1805 (review) --------- Co-authored-by: Martin Geisler <martin@geisler.net>
This was done a bit inconsistently before. We now skip all of these large blocks which are meant to be used as-is by the students. This removes 700 lines from the PO files. I found this during the review of #1651.
There were a few comments, but I think it’s better to make it all uniform and avoid these comments. The comment was about the v2 rewrite, but this is now done and so the comment is less useful. I also normalized the quotes to double-quotes instead of single-quotes. The latter is a literal string in TOML, but we don’t actually have any special characters to escape here.
Instead of always adding a new comment, just update the existing comment if one exists. This fixes #1834.
…date (#1871) Bumps the patch group in /src/bare-metal/aps/examples with 1 update: [log](https://github.com/rust-lang/log). Updates `log` from 0.4.20 to 0.4.21 Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.18.2 to 1.19.0. Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps the patch group with 4 updates: [log](https://github.com/rust-lang/log), [tempfile](https://github.com/Stebalien/tempfile), [cxx](https://github.com/dtolnay/cxx) and [cxx-build](https://github.com/dtolnay/cxx). Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…pdate (#1874) Bumps the patch group in /src/exercises/bare-metal/rtc with 1 update: [log](https://github.com/rust-lang/log). Updates `log` from 0.4.20 to 0.4.21 Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps the minor group with 2 updates: [scraper](https://github.com/causal-agent/scraper) and [tokio-websockets](https://github.com/Gelbpunkt/tokio-websockets). Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@djmitche Currently all PRs are marked as schedule change PRs. This is my try to propose a fix for this, but please review diligently, I'm no github actions expert, and I don't have an environment to test.
This is a typo, that actually @mgeisler stopped in my previous PR, I was just not around to fix it fast enough to make it to the previous merge. Thanks for the catch!
After #1528 and #1532, we now have actual slides which showcase the crates in action. So we can reclaim a few minutes by removing the slide which mentions Mockall and GoogleTest slide. The slide mentioned [proptest](https://docs.rs/proptest) and [rstest](https://docs.rs/rstest) as well. While I'm sure the libraries are useful, we don't have them imported into AOSP and I've never personally used them. We should therefore not advertise them yet at this point since they won't be useful to Android engineers. Of course we can mention things that are not in AOSP (or in Chromium), but I think we should do it in the speaker notes at most.
Before, we only installed and ran `mdbook-pandoc` when publishing the course — which means that a PR change could accidentally break the publish workflow. We now test that it works on every PR. From a discussion in #1704.
Added a dev theme to help with slide aspect ratio while updating content or for reviewing PRs. Fixes #1796. --------- Co-authored-by: Dustin J. Mitchell <djmitche@google.com> Co-authored-by: Martin Geisler <martin@geisler.net>
Bumps [mio](https://github.com/tokio-rs/mio) from 0.8.10 to 0.8.11.
Signed-off-by: geekvest <cuimoman@sohu.com>
This PR merges the Spanish (es) v.2 translation back to main. This requires just a syntactical review, as the partial PRs into this branch were reviewed already. You can skim this PR with the [GitHub CLI](https://cli.github.com/): gh pr diff 1879 | bat -l patch #1463 #284 --------- Co-authored-by: David Martínez Martí <deavid@google.com>
updated for cr2 and added some translations Part of #500
#1824 PR Changes
Thanks for the work so far, feel free to come back if you have more time!
Because `.zip()` is limited to the shorter length, the `.take()` call here is unnecessary. When explaining this solution I don't want to have to explain a call to a method that, used as it is, does nothing.
…es (#1885) These follow the flow of what I actually teach, which spends a significant amount of time on the latter slide. I think it's worthwhile to have a real flow documented in the teaching notes, both to make sure nothing gets forgotten and to structure the experience of teaching.
…1882) This diagram is misleading and I often explain that the character data of string literals resides in the executable's static data, with vtables working the same.
Clarify that the basics are stable, but dyn support is still missing. This slide was outdated and didn't explain the current state of stable correctly.
Once a new version of Pandoc is released that includes jgm/pandoc#9204 and jgm/pandoc#9353 (both merged), this will fix the emoji and symbol rendering issues in #1708. It doesn't seem to be possible to set fallback fonts with `luatexja-fontspec` (used to configure CJK fonts), which results in some missing symbols in the translations but at least renders the emoji properly. Closes #1708
A minor nitpick, but as someone new to the language I did spend a bit more time than I'd like to admit trying to understand the meaning of `allow` before realizing this is likely a typo. Maybe I still don't understand, and in that case I'd appreciate a correction!
…1876) This PR aims to do the following: 1. Refresh the Bengali Translations 2. Add new translations in line with #653 to complete up to 10%. 3. Corrections to existing translations. Edit: Recent commits bump up the % completed to 12. --------- Co-authored-by: abhik-bits <127435906+abhik-bits@users.noreply.github.com> Co-authored-by: Mir Wasi Ahmed <1697945+mirwasi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.