Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Winget package identifier #156

Closed
wants to merge 1 commit into from
Closed

Conversation

alyssadev
Copy link

Package is still stored in microsoft/winget-pkgs as ViGEm.HidHide. A new package could be submitted and users of the previous package migrated if the package identifier change is still needed; providing the updated version to users first.

The updated workflow shouldn't be executed for this release, as a fixed manifest has already been PR'd, see linked.

Related:
#155
microsoft/winget-pkgs#160057
microsoft/winget-pkgs#160054

Package is still stored in microsoft/winget-pkgs as ViGEm.HidHide. A new package could be submitted and users of the previous package migrated if the package identifier change is still needed; providing the updated version to users first.
@nefarius
Copy link
Owner

Why did you change the identifier to the one that's deprecated, I don't understand the point of this change, please elaborate.

@alyssadev
Copy link
Author

https://github.com/nefarius/HidHide/actions/runs/9617849637/job/26530498455 The issue is that nefarius.HidHide is not an existing package in Winget, and the action refuses to create a new package

@nefarius
Copy link
Owner

Well that's too bad then, I will not use that name anymore for reasons I explained quite thoroughly. Is there no "deprecate package X, replace with package Y" concept in winget? I am not really a fan of getting involved with these package managers myself, I barely have the time for maintenance without these extra distractions.

@alyssadev
Copy link
Author

related: microsoft/winget-cli#4344

But understandable. I'll see if I can make the PR creating the new package identifier.

@alyssadev alyssadev closed this Jun 27, 2024
@alyssadev alyssadev deleted the patch-1 branch June 27, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants