Fix bug where range variable is improperly dereferenced (hashicorp#217)

* Fix bug where range variable is improperly dereferenced * Add comment explaining why a value is copied
negz · Jul 19, 2017 · 8f75c1c · 8f75c1c
1 parent 6c27e07
commit 8f75c1c
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/google/metadata.go b/google/metadata.go
@@ -103,7 +103,10 @@ func expandComputeMetadata(m map[string]string) []*compute.MetadataItems {
 
 	idx := 0
 	for key, value := range m {
-		metadata[idx] = &compute.MetadataItems{Key: key, Value: &value}
+		// Make a copy of value as we need a ptr type; if we directly use 'value' then all items will reference the same
+		// memory address
+		vtmp := value
+		metadata[idx] = &compute.MetadataItems{Key: key, Value: &vtmp}
 		idx++
 	}