Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use go 1.23 #1046

Merged
merged 4 commits into from
Sep 20, 2024
Merged

Use go 1.23 #1046

merged 4 commits into from
Sep 20, 2024

Conversation

MalinAhlberg
Copy link
Contributor

Related issue(s) and PR(s)
This PR closes #1005

Description
GO.mods, Dockerfiles and workflow actions are updated.

How to test
Verify that all tests pass.

@MalinAhlberg MalinAhlberg marked this pull request as ready for review September 19, 2024 11:33
@MalinAhlberg MalinAhlberg requested a review from a team September 19, 2024 11:33
Copy link
Collaborator

@jbygdell jbygdell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run the following commands in each directory after changing the GO version in the go.mod file.

go get -t -u ./...
go mod tidy

That will ensure that all dependencies are updated to match the new GO version.

sda-admin/go.mod Outdated Show resolved Hide resolved
.github/workflows/code-linter.yaml Outdated Show resolved Hide resolved
sda-download/go.mod Outdated Show resolved Hide resolved
sda/go.mod Outdated Show resolved Hide resolved
@MalinAhlberg
Copy link
Contributor Author

Run the following commands in each directory after changing the GO version in the go.mod file.

go get -t -u ./...
go mod tidy

That will ensure that all dependencies are updated to match the new GO version.

After this, I had to reset the version of ristretto to v0.1.1, to avoid

  Error: internal/session/session.go:11:19: cannot use generic type ristretto.Cache[K z.Key, V any] without instantiation
51
  Error: internal/session/session.go:26:33: cannot use generic type ristretto.Cache[K z.Key, V any] without instantiation
52
  Error: internal/session/session.go:29:4: cannot use generic type ristretto.Config[K z.Key, V any] without instantiation (typecheck)
53
  package session

See also this: dgraph-io/ristretto#394.

Not sure if this should be handled in a more robust way.

@MalinAhlberg MalinAhlberg requested review from jbygdell and a team September 19, 2024 12:44
.github/workflows/code-linter.yaml Outdated Show resolved Hide resolved
.github/workflows/functionality.yml Outdated Show resolved Hide resolved
@MalinAhlberg MalinAhlberg force-pushed the chore/update-go-version branch 2 times, most recently from 3beb0a8 to b379d6d Compare September 20, 2024 07:41
only one go version is used, so matrix is not necessary
Copy link
Contributor

@nanjiangshu nanjiangshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jbygdell jbygdell added this pull request to the merge queue Sep 20, 2024
Merged via the queue into main with commit 91946dc Sep 20, 2024
26 checks passed
@jbygdell jbygdell deleted the chore/update-go-version branch September 20, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to GO 1.23
3 participants