Fix unicode to latin-1 translation. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The UC (unicode to Latin-1) option for the tr// operator was removed in perl 5.7. It is not possible to include the check conditionally if $] is e.g. less than 5.008 either since the code will not compile on newer versions of perl. I suggest we drop support for perl version 5.7 and below by removing the check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
UC(unicode to Latin-1) option for thetr//operator (see perldoc for perl 5.6 was removed in perl 5.7.0 (see perl570delta. It is not possible to include the statement conditional based on$]either, e.g. if$]is less than 5.008, since the code will anyway not compile on newer versions of perl (giving a syntax error).I suggest to drop support for perl version 5.7 and below by removing the transliteration (I think it is no longer correct to translate to unicode to latin-1 like that).
Note: I was not able to test if this fix works since I could not connect to the server. I get:
Note: This PR is part of assignment from pullrequest.club. See also this answer on stackoverflow.