Corrected a bug where setting fill or stroke to None actually made it…

… black rather than turning it off.
neilccbrown · Dec 9, 2024 · 4bf2bf9 · 4bf2bf9
1 parent 0484ef3
commit 4bf2bf9
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/public/public_libraries/strype/strype_graphics_internal.js b/public/public_libraries/strype/strype_graphics_internal.js
@@ -149,11 +149,15 @@ var $builtinmodule = function(name)  {
     });
     mod.canvas_setFill = new Sk.builtin.func(function(img, color) {
         const ctx = img.getContext("2d");
-        ctx.fillStyle = Sk.ffi.remapToJs(color);
+        let colorJs = Sk.ffi.remapToJs(color);
+        // Note 8 zeroes: this is fully transparent, not black:
+        ctx.fillStyle = colorJs == null ? "#00000000" : colorJs;
     });
     mod.canvas_setStroke = new Sk.builtin.func(function(img, color) {
         const ctx = img.getContext("2d");
-        ctx.strokeStyle = Sk.ffi.remapToJs(color);
+        let colorJs = Sk.ffi.remapToJs(color);
+        // Note 8 zeroes: this is fully transparent, not black:
+        ctx.strokeStyle = colorJs == null ? "#00000000" : colorJs;
     });
     mod.canvas_getPixel = new Sk.builtin.func(function(img, x, y) {
         const ctx = img.getContext("2d");