Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slurm-send-mail log file is only created if it already exists #31

Closed
neilmunday opened this issue Apr 7, 2022 · 1 comment
Closed
Assignees
Labels
bug Something isn't working
Milestone

Comments

@neilmunday
Copy link
Owner

neilmunday commented Apr 7, 2022

This block of code in slurm-send-mail.py controls whether a log file is used or not:

    if log_file and log_file.is_file():
        logging.basicConfig(
            format=log_format, datefmt=log_date, level=log_level,
            filename=log_file
        )
    else:
        logging.basicConfig(
            format=log_format, datefmt=log_date, level=log_level
        )

This code means that the log file is only used if the log file already exists!

@neilmunday neilmunday added the bug Something isn't working label Apr 7, 2022
@neilmunday neilmunday added this to the 2.6 milestone Apr 7, 2022
@neilmunday neilmunday self-assigned this Apr 7, 2022
@neilmunday neilmunday changed the title log files are only created if they already exist slurm-send-mail log file isnonly created if it already exists Apr 7, 2022
@neilmunday neilmunday changed the title slurm-send-mail log file isnonly created if it already exists slurm-send-mail log file is only created if it already exists Apr 7, 2022
neilmunday pushed a commit that referenced this issue Apr 7, 2022
@neilmunday
Copy link
Owner Author

Fixed in 2.6 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant