-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rational krylov #24
Rational krylov #24
Conversation
Extends the abstract_linop type to handle cases such as : C = alpha * A + beta * B
- Added `solve` as an argument for the rational arnoldi to enable the user to switch between different solvers. - Modified the tests accordingly.
…rface. This is mainly to make bicgstab usable with the rational arnoldi.
For some reasons it seems that the |
I figured there actually is an error in my test. I'll fix and re-commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok for kdim in BiCGSTAB, I appreciate the notes for the 'not needed' for future understanding, the new operators are super smart, the 'rtol' should make testing more robust, and the new rational Arnoldi is awesome! well done.
Most of the commits in this pull request are related to the implementation of the rational Arnoldi method. The most important contributions include:
rational_arnoldi_factorization
identity_linop
andaxpby_linop
(Additional fixes:
rtol
rather than1.0D-12
. This seems to prevent the failure of the tests forsvds
and other Krylov-related techniques.kdim
tobicgstab
to comply with thegmres
interface. It allows us to pass either solver to the rational Arnoldi if we wan to.